cr50: expose spihash PP polling to the host [chromiumos/platform/ec : firmware-cr50-mp-release-9308.87.B]

4 views
Skip to first unread message

ChromeOS Commit Bot (Gerrit)

unread,
Mar 23, 2018, 11:55:58 AM3/23/18
to Vadim Bendebury, Randall Spangler

ChromeOS Commit Bot merged this change.

View Change

Approvals: Vadim Bendebury: Looks good to me, approved; Ready; Verified
cr50: expose spihash PP polling to the host

When running the spihash command using gsctool (as opposed to the
running it from the Cr50 console), the operator needs to be prompted
when the PP button needs to be pressed.

This patch extends spihash command implementation by adding a new
subcommand for polling physical presence.

BRANCH=cr50, cr50-mp
BUG=b:73668125
TEST=with the appropriate gsctool changes the user is periodically
prompted to press the physical presence button, and eventually it
is possible to set up spi hash access to AP and EC.

Change-Id: I96aed1619d364c80a2f35ca8dc41241f1a444103
Signed-off-by: Vadim Bendebury <vbe...@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/930568
Reviewed-by: Randall Spangler <rspa...@chromium.org>
(cherry picked from commit d015bc937c0eecf1cb8f1b163874ea69c890dea4)
Reviewed-on: https://chromium-review.googlesource.com/942117
(cherry picked from commit 683dc5cfda7eb6246f9aea89d296597eb60ed765)
Reviewed-on: https://chromium-review.googlesource.com/949072
---
M board/cr50/usb_spi.c
M include/tpm_vendor_cmds.h
2 files changed, 52 insertions(+), 6 deletions(-)


To view, visit change 949072. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform/ec
Gerrit-Branch: firmware-cr50-mp-release-9308.87.B
Gerrit-Change-Id: I96aed1619d364c80a2f35ca8dc41241f1a444103
Gerrit-Change-Number: 949072
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: ChromeOS Commit Bot <chromeos-...@chromium.org>
Gerrit-Reviewer: Randall Spangler <rspa...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages