camera: Update portrait mode API interfacing [chromiumos/platform2 : release-R81-12871.B]

10 views
Skip to first unread message

Commit Bot (Gerrit)

unread,
Apr 8, 2020, 12:02:57 PM4/8/20
to Ren-Pei Zeng

Commit Bot submitted this change.

View Change

Approvals: Ren-Pei Zeng: Looks good to me, approved; Commit; Verified
camera: Update portrait mode API interfacing

BUG=b:141518864,chromium:1067793
TEST=deploy and take portrait photo by CCA

Cq-Depend: chrome-internal:2847272
Change-Id: I48f9dd862bf04c701acbbee51cd7bcb41d259897
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2136989
Tested-by: Ren-Pei Zeng <kam...@chromium.org>
Commit-Queue: Ren-Pei Zeng <kam...@chromium.org>
Reviewed-by: Hung-yu Wu <hy...@chromium.org>
(cherry picked from commit 4ba6236117b1e4b27e384229b671fa89d7ac9ee9)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2141403
Reviewed-by: Ren-Pei Zeng <kam...@chromium.org>
---
M camera/common/camera_gpu_algorithm.cc
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/camera/common/camera_gpu_algorithm.cc b/camera/common/camera_gpu_algorithm.cc
index e6d3ea3..3976a3c 100644
--- a/camera/common/camera_gpu_algorithm.cc
+++ b/camera/common/camera_gpu_algorithm.cc
@@ -8,6 +8,7 @@

#include <base/bind.h>
#include <base/logging.h>
+#include <base/numerics/safe_conversions.h>

#include "cros-camera/common.h"
#include "cros-camera/export.h"
@@ -133,8 +134,13 @@
callback(EINVAL);
return;
}
+ const creative_camera::PortraitCrosWrapper::Request portrait_request{
+ .width = base::checked_cast<int>(params.width),
+ .height = base::checked_cast<int>(params.height),
+ .orientation = base::checked_cast<int>(params.orientation),
+ };
if (!portrait_processor_.Process(
- req_id, params.width, params.height, params.orientation,
+ req_id, portrait_request,
static_cast<const uint8_t*>(
shm_map_.at(params.input_buffer_handle)->memory()),
static_cast<uint8_t*>(

To view, visit change 2141403. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform2
Gerrit-Branch: release-R81-12871.B
Gerrit-Change-Id: I48f9dd862bf04c701acbbee51cd7bcb41d259897
Gerrit-Change-Number: 2141403
Gerrit-PatchSet: 2
Gerrit-Owner: Ren-Pei Zeng <kam...@chromium.org>
Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
Gerrit-Reviewer: Ren-Pei Zeng <kam...@chromium.org>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages