Restrict tcsd input to uid root or group tss. [chromiumos/third_party/trousers : release-R20-2268.B]

1 view
Skip to first unread message

Darren Krahn (Code Review)

unread,
May 16, 2012, 12:24:01 PM5/16/12
to Luigi Semenzato
Darren Krahn has submitted this change and it was merged.

Change subject: Restrict tcsd input to uid root or group tss.
......................................................................


Restrict tcsd input to uid root or group tss.

This prevents DOS (or worse) attacks on tcsd by restricting its input to
processes running with UID root or GID tss.

BUG=chromium-os:25099
TEST=installed trousers, verified that /var/run/tcsd.socket is
srw-rw---- 1 root tss, and verified that I can still log on.

Change-Id: Id5ad5b33ca1e7322ab86eba5301c749bb1a0a366
---
M src/tcsd/svrside.c
1 file changed, 9 insertions(+), 2 deletions(-)

Approvals:
Darren Krahn: Verified
Luigi Semenzato: Looks good to me, approved


--
To view, visit https://gerrit.chromium.org/gerrit/22769
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5ad5b33ca1e7322ab86eba5301c749bb1a0a366
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/trousers
Gerrit-Branch: release-R20-2268.B
Gerrit-Owner: Darren Krahn <dkr...@chromium.org>
Gerrit-Reviewer: Darren Krahn <dkr...@chromium.org>
Gerrit-Reviewer: Luigi Semenzato <seme...@chromium.org>
Reply all
Reply to author
Forward
0 new messages