kerberos: refactor config parser enctypes retrieval [chromiumos/platform2 : master]

3 views

Skip to first unread message

Commit Bot (Gerrit)

unread,

Apr 8, 2020, 11:56:20 AM4/8/20

to Felipe Andrade, Maksim Ivanov, Roman Sorokin [CET], Tomasz Dobrowolski

Commit Bot submitted this change.

Approvals:
  Roman Sorokin [CET]: Looks good to me, but someone else must approve
  Maksim Ivanov: Looks good to me, approved
  Felipe Andrade: Commit; Verified

kerberos: refactor config parser enctypes retrieval

Refactor GetEncryptionTypes() to return a boolean error code. This way,
this method will not fail silently and we won't rely on the caller to
send a valid config. An invalid config is not expected to be sent to
GetEncryptionTypes() right now, but it's safer to cover this case.

BUG=chromium:1067874

TEST=cros_workon_make --board=amd64-generic --test kerberos

Change-Id: I8f630b7096101fbbd9097f8e7fc690bb71cbc96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2139977
Tested-by: Felipe Andrade <fsan...@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsor...@chromium.org>
Reviewed-by: Maksim Ivanov <em...@chromium.org>
Commit-Queue: Felipe Andrade <fsan...@chromium.org>
---
M kerberos/account_manager.cc
M kerberos/account_manager_test.cc
M kerberos/config_parser.cc
M kerberos/config_parser.h
M kerberos/config_parser_test.cc
5 files changed, 65 insertions(+), 37 deletions(-)

To view, visit change 2139977. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages