Revert "[autotest] Put dev server error strings in exception... [chromiumos/third_party/autotest : master]

1 view
Skip to first unread message

Chris Sosa (Code Review)

unread,
May 16, 2012, 2:13:32 AM5/16/12
to Chris Masone, Scott Zawalski
Chris Sosa has submitted this change and it was merged.

Change subject: Revert "[autotest] Put dev server error strings in exceptions"
......................................................................


Revert "[autotest] Put dev server error strings in exceptions"

This change exposed a bug in the old test_scheduler. The old test_scheduler
didn't do anything to suppress exceptions and aborts if the devserver returns
any exceptions.

This change is good as is and can be safely re-reverted once the old test_scheduler is robustified a little.

This reverts commit c807fcb56c57dbac1b193d92a90d59388c0cefe4

BUG=chromium-os:30915
TEST=Ran on autotest server with test_scheduler.

Change-Id: I22b9bbf87552c411c82b2d4e67fdbc33576eacb6
---
M client/common_lib/cros/dev_server.py
M client/common_lib/cros/dev_server_unittest.py
M frontend/afe/site_rpc_interface.py
M server/cros/control_file_getter.py
M server/cros/control_file_getter_unittest.py
M server/cros/dynamic_suite.py
6 files changed, 75 insertions(+), 100 deletions(-)

Approvals:
Chris Sosa: Verified; Looks good to me, approved


--
To view, visit https://gerrit.chromium.org/gerrit/22776
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22b9bbf87552c411c82b2d4e67fdbc33576eacb6
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Reply all
Reply to author
Forward
0 new messages