grunt/baseboard: Slow keyboard scan rate [chromiumos/platform/ec : firmware-grunt-11031.B]

4 views

Skip to first unread message

Commit Bot (Gerrit)

unread,

Apr 8, 2020, 11:26:21 AM4/8/20

to Devin Lu, Edward Hill, Ruy Cheng, Kevin Chiu

Commit Bot submitted this change.

Approvals:
  Edward Hill: Looks good to me, approved; Commit
  Devin Lu: Verified

grunt/baseboard: Slow keyboard scan rate

Slow the keyboard scan rate from 60 us to 80 us. This compensates the
additional delay added to the KBO line by H1.

BUG=b:153470574
BRANCH=grunt
TEST=make sure defect unit will not output t Key while pressing F3 key.

Change-Id: I9548ccc2368ac7be5ea566577a479e98291efb29
Signed-off-by: Devin Lu <Devi...@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2141372
Reviewed-by: Edward Hill <ec...@chromium.org>
(cherry picked from commit dbfc6ded455817d6de0ddd9ecfe454bc564d0362)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2141376
Commit-Queue: Edward Hill <ec...@chromium.org>
---
M baseboard/grunt/baseboard.c
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/baseboard/grunt/baseboard.c b/baseboard/grunt/baseboard.c
index 142b3b6..2c5d680 100644
--- a/baseboard/grunt/baseboard.c
+++ b/baseboard/grunt/baseboard.c
@@ -477,8 +477,13 @@
 
 /* Keyboard scan setting */
 struct keyboard_scan_config keyscan_config = {
-	/* Extra delay when KSO2 is tied to Cr50. */
-	.output_settle_us = 60,
+	/*
+	 * F3 key scan cycle completed but scan input is not
+	 * charging to logic high when EC start scan next
+	 * column for "T" key, so we set .output_settle_us
+	 * to 80us
+	 */
+	.output_settle_us = 80,
 	.debounce_down_us = 6 * MSEC,
 	.debounce_up_us = 30 * MSEC,
 	.scan_period_us = 1500,

To view, visit change 2141376. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages