cr50: Allow spihash extension command over USB [chromiumos/platform/ec : firmware-cr50-mp-release-9308.87.B]

2 views
Skip to first unread message

ChromeOS Commit Bot (Gerrit)

unread,
Mar 23, 2018, 11:55:58 AM3/23/18
to Vadim Bendebury, Mary Ruthven

ChromeOS Commit Bot merged this change.

View Change

Approvals: Vadim Bendebury: Looks good to me, approved; Ready; Verified
cr50: Allow spihash extension command over USB

Execution of this command requires physical presence on the DUT, this
is why it is save to allow it over USB.

BRANCH=cr50, cr50-mp
BUG=chromium:812880
TEST=using modified gsctool verified that the command goes through and
physical presence indication is requested

Change-Id: I0aa371d8aaa5a480cc12d5d16edad8497142f4b4
Signed-off-by: Vadim Bendebury <vbe...@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/927796
Reviewed-by: Mary Ruthven <mrut...@chromium.org>
(cherry picked from commit 53ca6cfbdf3a54d574f140a3eaf926eb80a53697)
Reviewed-on: https://chromium-review.googlesource.com/942115
(cherry picked from commit 84a21b4425b1f91d6c2a4887af8b3cd75782bc04)
Reviewed-on: https://chromium-review.googlesource.com/949070
---
M common/extension.c
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/common/extension.c b/common/extension.c
index 63d20de..610db49 100644
--- a/common/extension.c
+++ b/common/extension.c
@@ -69,6 +69,7 @@
#endif /* defined(CR50_DEV) */
case EXTENSION_POST_RESET: /* Always need to be able to reset. */
case VENDOR_CC_GET_BOARD_ID:
+ case VENDOR_CC_SPI_HASH: /* This will require physical presence. */
case VENDOR_CC_TURN_UPDATE_ON:

/*

To view, visit change 949070. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform/ec
Gerrit-Branch: firmware-cr50-mp-release-9308.87.B
Gerrit-Change-Id: I0aa371d8aaa5a480cc12d5d16edad8497142f4b4
Gerrit-Change-Number: 949070
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: ChromeOS Commit Bot <chromeos-...@chromium.org>
Gerrit-Reviewer: Mary Ruthven <mrut...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages