Issue 35715 in chromium-os: Add calls to session manager to store and retrieve local account policy

1 view
Skip to first unread message

chrom...@googlecode.com

unread,
Oct 25, 2012, 7:25:26 AM10/25/12
to chromium...@chromium.org
Status: Started
Owner: mnis...@chromium.org
Labels: Type-Feature Pri-2 Area-Enterprise Feature-PublicAccounts Arch-All
Mstone-25

New issue 35715 by mnis...@chromium.org: Add calls to session manager to
store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715

Policy for local accounts (as used in the public accounts feature) will be
brokered by session_manager, similar to what it already does for device
policy and user policy. We'll have to add the necessary DBus calls and add
policy reading/writing logic.

chrom...@googlecode.com

unread,
Oct 25, 2012, 7:26:26 AM10/25/12
to chromium...@chromium.org
Issue 35715: Add calls to session manager to store and retrieve local
account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715

This issue is now blocking issue chromium-os:34866.
See http://code.google.com/p/chromium-os/issues/detail?id=34866

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

chrom...@googlecode.com

unread,
Nov 2, 2012, 12:16:29 PM11/2/12
to chromium...@chromium.org
Updates:
Cc: chrome-...@google.com

Comment #2 on issue 35715 by bugdro...@chromium.org: Add calls to session
manager to store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715#c2

Project: chromiumos/platform/login_manager
Branch : master
Author : Mattias Nissler <mnis...@chromium.org>
Commit : 33ed87c0483c8c1b37cfe94e0fe9e8a4047c356f

Code Review +2: Chris Masone
Verified +1: Mattias Nissler
Change-Id : Ib1a9e2f2d7ee4ea107faf786e2a17f1ce009752e
Reviewed-at : https://gerrit.chromium.org/gerrit/36687

session_manager: Make PolicyService not own PolicyKey.

This is in prepration for local account policy support, in which case
the main owner key will be used for verification and accessed by several
PolicyService instances.

BUG=chromium-os:35715
TEST=Compiles and passes tests.

M device_policy_service.cc
M device_policy_service.h
M device_policy_service_unittest.cc
M mock_constructors.cc
M policy_service.cc
M policy_service.h
M policy_service_unittest.cc
M session_manager_service.cc
M session_manager_service.h
M user_policy_service.cc
M user_policy_service.h
M user_policy_service_factory.cc
M user_policy_service_unittest.cc

chrom...@googlecode.com

unread,
Nov 14, 2012, 4:22:08 AM11/14/12
to chromium...@chromium.org

Comment #3 on issue 35715 by bugdro...@chromium.org: Add calls to session
manager to store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715#c3

Project: chromiumos/platform/login_manager
Branch : master
Author : Mattias Nissler <mnis...@chromium.org>
Commit : 4ddcec96ba4843bd3babb168faf2905963308bcd

Code Review +2: Mattias Nissler
Verified +1: Mattias Nissler
Change-Id : I488c3d93ff8d9352cd5bfa211588806e32d43b54
Reviewed-at : https://gerrit.chromium.org/gerrit/37719

session_manager: Split out PolicyService::Initialize

The different subclasses of PolicyService require different
initialization sequences, in particular with the to-be-added local
accounts PolicyService that shouldn't load the policy key. This patch
makes the initialization the concern of the subclass.

BUG=chromium-os:35715
TEST=Everything works as before, compiles and passes tests.

M device_policy_service.cc
M device_policy_service.h
M mock_policy_service.h
M policy_service.cc
M policy_service.h
M policy_service_unittest.cc
M session_manager_service.cc
M session_manager_unittest.cc
M user_policy_service_factory.cc
M user_policy_service_unittest.cc

chrom...@googlecode.com

unread,
Nov 16, 2012, 10:31:01 AM11/16/12
to chromium...@chromium.org

Comment #8 on issue 35715 by bugdro...@chromium.org: Add calls to session
manager to store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715#c8

Project: chromiumos/platform/system_api
Branch : master
Author : Mattias Nissler <mnis...@chromium.org>
Commit : 16e22d62da60372e70fb274a2bace6c10bf53003

Code Review +2: Chris Masone
Verified +1: Mattias Nissler
Change-Id : I36fce57e233ac5615dfc048272ff37d581709a75
Reviewed-at : https://gerrit.chromium.org/gerrit/37910

Add DBus constants for local account policy calls to session_manager.

BUG=chromium-os:35715
TEST=None

M dbus/service_constants.h

chrom...@googlecode.com

unread,
Nov 19, 2012, 12:47:54 PM11/19/12
to chromium...@chromium.org

Comment #9 on issue 35715 by bugdro...@chromium.org: Add calls to session
manager to store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715#c9

Project: chromiumos/overlays/chromiumos-overlay
Branch : master
Author : Mattias Nissler <mnis...@chromium.org>
Commit : 3c9a93e1ddf1f0c7cee3c026094a20cd59ed740a

Code Review +2: Julian Pastarmov
Verified +1: Mattias Nissler
Change-Id : I5619506ef36369feedecd308b56911b13b4f1838
Reviewed-at : https://gerrit.chromium.org/gerrit/38306

protofiles: Roll in device-local account device settings.

BUG=chromium-os:35715
TEST=None

A chromeos-base/protofiles/protofiles-0.0.1-r10.ebuild
D chromeos-base/protofiles/protofiles-0.0.1-r9.ebuild

chrom...@googlecode.com

unread,
Nov 20, 2012, 9:02:17 AM11/20/12
to chromium...@chromium.org

Comment #10 on issue 35715 by bugdro...@chromium.org: Add calls to session
manager to store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715#c10

Project: chromiumos/platform/login_manager
Branch : master
Author : Mattias Nissler <mnis...@chromium.org>
Commit : 198046af1c357928c994b225cf2e231ac3c6e659

Code Review +2: Mattias Nissler
Verified +1: Mattias Nissler
Change-Id : I07b48ff57c9ce3cf73dac828cc1e7e5c2a41a290
Reviewed-at : https://gerrit.chromium.org/gerrit/37720

session_manager: Implement DBus interface for local accounts policy.

This adds the DBus calls for storing and receiving policy for local
accounts, as well as the code that reads/writes the policy data to/from
disk.

BUG=chromium-os:35715
TEST=unit tests

M SessionManager.conf
A device_local_account_policy_service.cc
A device_local_account_policy_service.h
A device_local_account_policy_service_unittest.cc
M device_policy_service.cc
M device_policy_service.h
M device_policy_service_unittest.cc
M interface.cc
M interface.h
M mock_device_policy_service.h
M session_manager.xml
M session_manager_service.cc
M session_manager_service.h
M session_manager_unittest.cc
M session_manager_unittest.h

chrom...@googlecode.com

unread,
Nov 23, 2012, 6:59:32 AM11/23/12
to chromium...@chromium.org
Updates:
Status: Fixed

Comment #11 on issue 35715 by mnis...@chromium.org: Add calls to session
manager to store and retrieve local account policy
http://code.google.com/p/chromium-os/issues/detail?id=35715

(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages