Issue 30824 in chromium-os: HWTest stage failing on canaries

[chrom...@googlecode.com]

Status: Untriaged
Owner: sco...@chromium.org
Labels: Type-Bug Pri-0 Area-Build Sev-0

New issue 30824 by crai...@chromium.org: HWTest stage failing on canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

The HWTest [bvt] stage is failing on the canaries.

[chrom...@googlecode.com]

Comment #1 on issue 30824 by crai...@chromium.org: HWTest stage failing on
canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

Build failed with:

Traceback (most recent call last):
File "/b/cbuild/x86-zgb-canary-master/chromite/buildbot/builderstage.py",
line 243, in Run
self._PerformStage()

File "/b/cbuild/x86-zgb-canary-master/chromite/buildbot/cbuildbot_stages.py",
line 940, in _PerformStage
self._options.debug)

File "/b/cbuild/x86-zgb-canary-master/chromite/buildbot/cbuildbot_commands.py",
line 424, in RunHWTestSuite
cros_lib.RunCommand(cmd)
File "/b/cbuild/x86-zgb-canary-master/chromite/lib/cros_build_lib.py",
line 413, in RunCommand
raise RunCommandError(msg, cmd_result)
RunCommandError: Failed
command "['/b/build_internal/scripts/slave-internal/autotest_rpc/autotest_rpc_client.py', 'master2', 'RunSuite', '-i', 'x86-zgb-release/R21-2273.0.0', '-s', 'bvt', '-b', 'x86-zgb', '-p', 'bvt']",
cwd=None, extra env=None

[chrom...@googlecode.com]

Updates:
Status: Assigned
Labels: -Pri-0 -Area-Build Pri-1 Area-Lab

Comment #2 on issue 30824 by sco...@chromium.org: HWTest stage failing on
canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

FAILED RPC CALL: create_suite_job {'check_hosts':
True, 'suite_name': 'bvt', 'build': 'x86-zgb-release/R21-2273.0.0', 'pool': 'bvt', 'board': 'x86-zgb'}

Traceback (most recent call last):

File "/home/scottz/autotest/site_utils/run_suite.py", line 278, in
<module>
sys.exit(main())
File "/home/scottz/autotest/site_utils/run_suite.py", line 220, in main
pool=options.pool)

File "/usr/local/google/home/scottz/chromeos/src/third_party/autotest/files/server/cros/frontend_wrappers.py",
line 53, in func_retry
raise e
autotest_lib.client.common_lib.error.ControlFileNotFound:
ControlFileNotFound: test_suites/control.bvt is not unique.

Traceback (most recent call last):

File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line
96, in dispatchRequest
results['result'] = self.invokeServiceEndpoint(meth, args)
File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line
134, in invokeServiceEndpoint
return meth(*args)
File "/usr/local/autotest/frontend/afe/rpc_handler.py", line 120, in
new_fn
return f(*args, **keyword_args)
File "/usr/local/autotest/frontend/afe/site_rpc_interface.py", line 83,
in create_suite_job
control_file_in = getter.get_control_file_contents_by_name(suite_name)
File "/usr/local/autotest/server/cros/control_file_getter.py", line 106,
in get_control_file_contents_by_name
raise ControlFileNotFound(test_name + ' is not unique.')
ControlFileNotFound: test_suites/control.bvt is not unique.


We need to be more strict when we check for test suite control files.
Having control.bvt and control.bvt_bigger caused this conflict. Should be
easy enough to fix but the original change has been reverted for now.

[chrom...@googlecode.com]

Comment #3 on issue 30824 by bugdro...@chromium.org: HWTest stage failing
on canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824#c3

Commit: c3ad52cb9c8c59be8476aef1f249b87cb0d37bfc
Email: sco...@chromium.org

Revert "Add a bvt test suite in that uses 8 machines instead of 4."

This causes an issue with our searching for unique control files. Reverting
for now a proper fix will follow later on.

BUG=chromium-os:30824
This reverts commit bc04e9b7d3300226ab579088f4958e10d91f0c8c

Change-Id: I4b36550f888e263a90953d04b9c639b5be001c1d
Reviewed-on: https://gerrit.chromium.org/gerrit/22473
Commit-Ready: Scott Zawalski <sco...@chromium.org>
Reviewed-by: Scott Zawalski <sco...@chromium.org>
Tested-by: Scott Zawalski <sco...@chromium.org>

D test_suites/control.bvt_bigger

[chrom...@googlecode.com]

Updates:
Cc: kr...@chromium.org

Comment #4 on issue 30824 by crai...@chromium.org: HWTest stage failing on
canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

(No comment was entered for this change.)

[chrom...@googlecode.com]

Updates:
Cc: cma...@chromium.org

Comment #5 on issue 30824 by sco...@chromium.org: HWTest stage failing on
canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

+cmasone
Was this fixed with your other change?

[chrom...@googlecode.com]

Comment #6 on issue 30824 by cma...@chromium.org: HWTest stage failing on
canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

Which other change? The one to address 'regression'
vs 'kernel.nightly.regression' in suite_scheduler? That would not have
impacted this, no.

Do you want me to take this as well? It shouldn't be hard.

[chrom...@googlecode.com]

Updates:
Owner: cma...@chromium.org
Labels: iteration-56

Comment #7 on issue 30824 by sco...@chromium.org: HWTest stage failing on
canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824

Sure might as well. Thanks

[chrom...@googlecode.com]

Updates:
Status: Fixed

Comment #9 on issue 30824 by bugdro...@chromium.org: HWTest stage failing
on canaries
http://code.google.com/p/chromium-os/issues/detail?id=30824#c9

Commit: a64fdc1ee551c10559941c65ed57c6361dd8a168
Email: cma...@chromium.org

[autotest] Search for control files more precisely

In control_file_getter.DevServerGetter, we use a regexp to go through
the list of files returned from the dev server, looking for the
control file the caller wants to run. The existing re has no anchor
at the end, so it was basically doing prefix matching. So, looking
for 'control.bvt' would be non-unique fail if 'control.bvt' and
'control.bvt_bigger' both existed.

This CL adds an anchor at the end, so that 'control.bvt' matches only
'control.bvt', 'dummy_Pass/control' matches only that, etc etc etc.

BUG=chromium-os:30824
TEST=use run_suite to run the 'dummy' suite
TEST=create a 'dummy_x1' suite control file, and run that with run_suite as
well.
STATUS=Fixed

Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Reviewed-on: https://gerrit.chromium.org/gerrit/22849
Tested-by: Chris Masone <cma...@chromium.org>
Reviewed-by: Scott Zawalski <sco...@chromium.org>
Commit-Ready: Chris Masone <cma...@chromium.org>

M server/cros/control_file_getter.py