[Status Report] Migration to new Mojo types - 12/15/2019

28 views
Skip to first unread message

Mario Sanchez Prada

unread,
Dec 16, 2019, 7:47:44 AM12/16/19
to chromium-mojo, platform-architecture-dev

Hi all,

It seems this is the last report of the year (there will be more in January, though, but probably not many more ;-)), so here we are again reporting on the progress of this task... which is nearly done!

As you can check in the table at the bottom, Blink is 100% done now, //content is at 99.81% and the other directories altogether are at the 97.93% mark (and these include //components/arc, which can't be migrated now - see [2]), so almost there! Additionally, we also landed a small update to the PRESUBMIT.py script [3] so that we now raise errors when old types are introduced in Blink and warnings everywhere else but in //components/arc (whose migration needs to be agreed with the folks maintaining libchrome for Android, see [2] again).

Last, it's worth noting that, similarly to what we did in last report for Blink only, all numbers here now take into account the false positives that the grep query would find, which have been now subtracted from the numbers throughout the whole spreadsheet also for //content and "others" now, thanks to the efforts of Julie who did the exhaustive search needed and updated the spreadsheet (see more details at [1])

Now I leave you with the graph reports below... Happy holidays and happy new year in advance! :-)


10/31/2019 11/7/2019 11/15/2019 11/23/2019 11/30/2019 12/15/2019
Blink 3 3 3 3 1 0
Content 184 159 144 93 25 3
Other 434 360 320 251 121 58
TOTAL 621 522 467 347 147 61



10/31/2019 11/7/2019 11/15/2019 11/23/2019 11/30/2019 12/15/2019
common/associated_interfaces 0 0 0 0 0 0
common/loader 0 0 0 0 0 0
public/common 0 0 0 0 0 0
public/platform 0 0 0 0 0 0
renderer/controller 0 0 0 0 0 0
renderer/core 2 2 2 2 0 0
renderer/modules 0 0 0 0 0 0
renderer/platform 1 1 1 1 1 0
tools/blinkpy 0 0 0 0 0 0
TOTAL 3 3 3 3 1 0



10/31/2019 11/7/2019 11/15/2019 11/23/2019 11/30/2019 12/15/2019
app_shim_remote_cocoa 0 0 0 0 0 0
browser 143 122 110 64 15 2
child 0 0 0 0 0 0
common 2 1 1 1 1 1
gpu 0 0 0 0 0 0
ppapi_plugin 0 0 0 0 0 0
public 14 14 13 9 8 0
renderer 20 17 15 14 1 0
shell 0 0 0 0 0 0
test 5 5 5 5 0 0
utility 0 0 0 0 0 0
TOTAL 184 159 144 93 25 3



10/31/2019 11/7/2019 11/15/2019 11/23/2019 11/30/2019 12/15/2019
android_webview 6 5 4 1 0 0
ash 4 4 4 4 4 3
cc 1 1 1 1 1 0
chrome 71 66 49 42 23 10
chromecast 17 15 14 13 12 0
chromeos 0 0 0 0 1 0
components 40 27 23 21 20 11
device 0 0 0 0 0 0
docs 2 2 2 2 2 2
extensions 19 18 14 13 0 0
fuchsia 0 0 0 0 0 0
google_apis 4 1 1 1 1 0
gpu 0 0 0 0 0 0
headless 1 1 1 1 0 0
ios 2 2 2 2 2 2
ipc 15 15 15 14 14 6
jingle 1 0 0 0 0 0
media 46 25 15 4 3 0
mojo 3 4 3 3 3 3
remoting 0 0 0 0 0 0
sandbox 0 0 0 0 0 0
services 192 172 171 128 34 21
skia 0 0 0 0 0 0
storage 1 0 0 0 0 0
ui 8 1 0 0 0 0
url 0 0 0 0 0 0
TOTAL 434 360 320 251 121 58


Project Completion (%)
Blink 100.00%
Content 99.81%
Other 97.93%
Global 98.73%

Find more detail in the base spreadsheet at:
https://docs.google.com/spreadsheets/d/1khYVrfnN74RSDqqXgCFlG9fI89IKWA9J32Ln_2ZcTaU

Thanks,
Mario

[1] https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/9vuGL48Lxik/6YscqLI5AwAJ
[2] https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/BRK0Xeu7bgQ/LWL2ELAOAwAJ
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1961908

Kentaro Hara

unread,
Dec 16, 2019, 8:12:08 AM12/16/19
to Mario Sanchez Prada, chromium-mojo, platform-architecture-dev
Thank you very much for sending the impressive report at the end of 2019 :)

Happy holidays!


--
You received this message because you are subscribed to the Google Groups "chromium-mojo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-moj...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-mojo/e2e9b885-7453-ee2c-531e-108165882b29%40igalia.com.


--
Kentaro Hara, Tokyo, Japan

Dave Tapuska

unread,
Dec 16, 2019, 10:06:29 AM12/16/19
to Kentaro Hara, Mario Sanchez Prada, chromium-mojo, platform-architecture-dev
I think we probably are at the point we need bugs for the problematic cases. Do we have a list of bugs for those?

dave.

You received this message because you are subscribed to the Google Groups "platform-architecture-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to platform-architect...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CABg10jwpo6p1tiyZE6%3D0TZKVorv%2BZ2P7kJtDj3%2BjbVAM8bmgtg%40mail.gmail.com.

Mario Sanchez Prada

unread,
Dec 18, 2019, 12:52:30 PM12/18/19
to Dave Tapuska, Kentaro Hara, chromium-mojo, platform-architecture-dev, Hidehiko Abe

Hi Dave,

Sorry for the late reply. I think we can start filing bugs blocking crbug.com/955171, if that's ok?

For now I've only filed one bug to track the issue with //components/arc, where I wrote a summary of the discussion from the ML at [1], hoping we can better get feedback from the Android/libchrome folks that way (please feel free to add anyone that you think might help to Cc). See it at crbug.com1035484.

Will file more bugs as they are needed, of course.

Thanks,
Mario

[1] https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/BRK0Xeu7bgQ/LWL2ELAOAwAJ

Reply all
Reply to author
Forward
0 new messages