Android WebView mojo service

23 views
Skip to first unread message

Shimi Zhang

unread,
Dec 27, 2018, 6:18:09 PM12/27/18
to chromi...@chromium.org, chan...@chromium.org, bo...@chromium.org
Hi chromium-mojo,

I am adding some mojo interface (sorry, Googlers only doc) for Android WebView, my current implementation is to register them to content_browser mojo service and add them to manifest overlay with a new capacity. However, from crbug.com/806394, it looks like the preferred way is to add a mojo service for WebView layer for embedder level features.

I saw some embedder features in Chrome are reusing content_browser and few others are using chrome's own service, so got confused, want to ask which is the right direction?

If we go with adding a new service, I think I need something very similar to ChromeService. I feel I'll need to duplicate almost everything there though.

Thanks!

Colin Blundell

unread,
Dec 28, 2018, 6:45:39 AM12/28/18
to Shimi Zhang, b...@chromium.org, chromi...@chromium.org, chan...@chromium.org, bo...@chromium.org
+Ben Goodger (Google) 

Hi Shimi,

Ben had been working to eliminate overlays in favor of distinct services. I'm not familiar with where the work/thinking is at currently on that though. Ben, do you have a best practice here?

Thanks,

Colin

--
You received this message because you are subscribed to the Google Groups "chromium-mojo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-moj...@chromium.org.
To post to this group, send email to chromi...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-mojo/CA%2BjkKuntVs%2BvFwyXO-9-CC6UU91KwH_08fKkKaB3waEHUDM%3DBw%40mail.gmail.com.

Ken Rockot

unread,
Jan 6, 2019, 10:23:10 AM1/6/19
to Colin Blundell, Shimi Zhang, b...@chromium.org, chromium-mojo, Changwan Ryu, bo...@chromium.org
It's still not clear to me what we really want to do with content embedders for stuff like this. Since there's already an overlay for WebView and that's the simplest option, please feel free to go with that for now. I think we may have a better plan some time later in Q1.

Shimi Zhang

unread,
Jan 7, 2019, 12:54:32 PM1/7/19
to Ken Rockot, Colin Blundell, b...@chromium.org, chromium-mojo, Changwan Ryu, bo...@chromium.org
Thanks Ken! I'll go with the overlay way for now.

On the other hand, I was experimenting the embedder service last week, there were bunch of issues I encountered with (mostly how to do X), off the top of my head:

I need to have WebView service under content packaged services, otherwise it will throw me an error message.
It seems we are deprecating service_manifest gn template, but I didn't see an alternative way for that.

I feel both are documentation issues though, hope my feedback could give some ideas.

Reply all
Reply to author
Forward
0 new messages