Removing [Stable] interfaces

[Andrew Moylan]

Hi, in situations where a [Stable] interface is no longer needed and there are no longer any backwards compatibility requirements, is it fine to bypass the presubmit that otherwise prevents deletion of the [Stable] interface?

[Ken Rockot]

On Thu, Sep 19, 2024 at 3:19 PM 'Andrew Moylan' via chromium-mojo <chromi...@chromium.org> wrote:

Hi, in situations where a [Stable] interface is no longer needed and there are no longer any backwards compatibility requirements, is it fine to bypass the presubmit that otherwise prevents deletion of the [Stable] interface?

Yes, as long as you're sure you aren't going to break something :)

If there's definitely nobody calling that method, and all other methods on the interface specify explicit ordinals (@n), it's safe. As an added precaution I would also suggest not making any other mojom changes in the same CL.

--
You received this message because you are subscribed to the Google Groups "chromium-mojo" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-moj...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-mojo/f17146a6-5390-4eba-b962-be665fb3fbd4n%40chromium.org.