--
You received this message because you are subscribed to the Google Groups "chromium-hterm" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-hterm/24f4d9b4-6edb-48af-945a-c38fa5d13656%40chromium.org.
we haven't done any real performance tests on the code base. focus was on correctness/stability, and making sure things were "good enough". at this point, i would say we're hitting those marks :).i wouldn't be surprised if there was room for improvement here. we know we are somewhat limited by the FSP integration as sometimes the Files app requests are not as efficient as they could be. but for bulk transfers, i don't think that should apply.there aren't any tunables available today other than whatever the ssh command line and ssh_config options provide. and i don't think it provides any in this regard.Secure Shell itself isn't `sftp` ... it's a JS implementation of the SFTP protocol that uses `ssh` for transport. so we use the buffers that `ssh` uses which, iirc, tend to be tuned for interactive rather than bulk.
On May 2, 2017 4:32 PM, "Mike Frysinger" wrote:we haven't done any real performance tests on the code base. focus was on correctness/stability, and making sure things were "good enough". at this point, i would say we're hitting those marks :).i wouldn't be surprised if there was room for improvement here. we know we are somewhat limited by the FSP integration as sometimes the Files app requests are not as efficient as they could be. but for bulk transfers, i don't think that should apply.there aren't any tunables available today other than whatever the ssh command line and ssh_config options provide. and i don't think it provides any in this regard.Secure Shell itself isn't `sftp` ... it's a JS implementation of the SFTP protocol that uses `ssh` for transport. so we use the buffers that `ssh` uses which, iirc, tend to be tuned for interactive rather than bulk.Well, that sounds good - the part that I mainly suspect is the request size of the read requests, not the SSH-level transport buffers (my HTTP example shows that these aren't quite optimal either, but that may be something for me to research regarding the SSH command line).Do you happen to know where the read request size is coming from - is the SFTP mount always using whatever request size the underlying read request from the OS was using (e.g. the Files app), or are request sizes changed/reduced to fit some internal buffers/limits?
If not, I'll do my own digging.If the SFTP protocol implementation does something with the request sizes, that may be possible to change - if it doesn't but just forwards the OS-provided sizes, changes to the Files app (to copy files using a larger block size) as well as some other apps (e.g. the media player) may be advisable. This, or a caching layer could be put inside the SFTP mount support.