Extension Icon Incorrect

[Nick Hanson]

On both Chrome and Edge's most up to date browsers I am seeing a silly icon instead of the normal icon that always used to be there.  This new weird icon is on every computer I own, even my work computer.  Perhaps this is an easy fix?

This is the way the icon looks currently

[Mike Frysinger]

this was reported in another thread, and it's been fixed in newer versions

-mike

--
You received this message because you are subscribed to the Google Groups "chromium-hterm" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-hter...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-hterm/44ee6d2f-004c-4630-bb88-af96568a4198n%40chromium.org.

[dmenest “‫دیمِنِست‬‎” Menestrina]

Is there any more info available on the issue with the extension icon?  I'm on v0.62 and I'm getting a "C" instead of the correct icon.  I'm on ChromeOS stable.  Here's a screenshot:

  https://screenshot.googleplex.com/9hKFdddA939cEVE

Thanks!

david

[Mike Frysinger]

that's a diff issue than this thread.  you're talking about shortcut/installed icons.  that has never worked afaik.  i don't know how Chrome determines what icon to use.

you're seeing a "C" because the title of the page you're creating a shortcut to is "Connection Dialog", and Chrome dynamically generates an icon with the first letter of the title.

-mike

[dmenest]

OK, the way this came up is I had to switch laptops and on the new laptop the launcher icon was not showing up properly.  The "create shortcut" flow is the documented process for getting a launcher pinned to the dock on ChromeOS.

I tried the same on various other internal websites (e.g. critique) and they all correctly get a launcher icon.  I figured there might be something busted with the extension's favicon so I took a look.  Interestingly, the nassh_connect_dialog.html does not link to a favicon.  Would it be reasonable to propose adding the favicon link in the HTML?

Thanks,

david

--

Women, Life, Freedom  زن، زندگی، آزادی

•  David Menestrina   •  Software Engineer, Bouncer   •  dmenest@google.com   •  go/help-iranian-googlers

[Mike Frysinger]

i don't have a prob with adding icon links in the html, but as i said, i have no idea what the shortcut code is looking for, or where/whether this logic is even documented.

extension windows already inherit a default icon via the extension manifest which you can see in the tab strip in your screenshot, but clearly Chrome's logic is ignoring that.

-mike

[Mike Frysinger]

looks like i fixed this 4 years ago for connected systems and just forgot about it.  i posted a change for the connection dialog and should be in the next release.

-mike

[dragon788]

On ChromeOS it was cool that the icon changed a bit depending on the screen resolution, so systems where 100% was 1366x768 vs 100% at 1536x836 or 70% (but panel native) at 1920x1080 would have different icons depending on the "zoom". The switch to the extension will certainly make things more cross system compatible but harder to customize much.

[Mike Frysinger]

we still provide multiple resolutions for the icon, including in the html pages.  so that shouldn't go away in theory.  but i don't know how dynamic Chrome's algorithm is here.

-mike