The dropped extensions sidebar api

373 views
Skip to first unread message

trappedIntoCode

unread,
Mar 10, 2012, 12:40:00 PM3/10/12
to Chromium-extensions
Hello. I want to checkout the chromium source revision with dropped
experimental sidebar api.

Can I get the last revision no from somewhere, before the code was
removed?

Mike West

unread,
Mar 11, 2012, 11:21:30 AM3/11/12
to Chromium-extensions, trappedIntoCode
The sidebar API was removed in http://crrev.com/116901

http://commondatastorage.googleapis.com/chromium-browser-continuous/index.html?path=Linux/116873/
looks like the most recent Linux build with the API. That should be a
good start for your experimentations. I wouldn't recommend running it
as your main browser though, for a variety of reasons

-mike

On Mar 10, 6:40 pm, trappedIntoCode <trapped....@gmail.com>
wrote:

trappedIntoCode

unread,
Mar 11, 2012, 12:49:47 PM3/11/12
to Chromium-extensions
Thanks Mike.

The sidebar directory disappears after 77159.

My requirement is for Windows, so I will eventually checkout something
around chrome 10.x.x.x,
study the patch and try to see if I can mod it for current trunk. I
also want it to persist across tabs.
Similar to FF sidebar.

I wonder if source tree has gone through changes that will totally
make the old patches useless.

Thanks again





On Mar 11, 8:21 pm, Mike West <mk...@chromium.org> wrote:
> The sidebar API was removed inhttp://crrev.com/116901
>
> http://commondatastorage.googleapis.com/chromium-browser-continuous/i...
> looks like the most recent Linux build with the API. That should be a
> good start for your experimentations. I wouldn't recommend running it
> as your main browser though, for a variety of reasons
>
> -mike
>
> On Mar 10, 6:40 pm, trappedIntoCode <trapped.into.c...@gmail.com>

Adam Barth

unread,
Mar 11, 2012, 1:14:27 PM3/11/12
to trappedIntoCode, Chromium-extensions
On Sun, Mar 11, 2012 at 9:49 AM, trappedIntoCode
<trapped....@gmail.com> wrote:
> Thanks Mike.
>
> The sidebar directory disappears after 77159.
>
> My requirement is for Windows, so I will eventually checkout something
> around chrome 10.x.x.x,
> study the patch and try to see if I can mod it for current trunk. I
> also want it to persist across tabs.
> Similar to FF sidebar.
>
> I wonder if source tree has gone through changes that will totally
> make the old patches useless.

That's very likely. Since then the "chrome" module has been
refactored into "content" and "chrome".

Adam


> On Mar 11, 8:21 pm, Mike West <mk...@chromium.org> wrote:
>> The sidebar API was removed inhttp://crrev.com/116901
>>
>> http://commondatastorage.googleapis.com/chromium-browser-continuous/i...
>> looks like the most recent Linux build with the API. That should be a
>> good start for your experimentations. I wouldn't recommend running it
>> as your main browser though, for a variety of reasons
>>
>> -mike
>>
>> On Mar 10, 6:40 pm, trappedIntoCode <trapped.into.c...@gmail.com>
>> wrote:
>>
>>
>>
>>
>>
>>
>>
>> > Hello. I want to checkout the chromium source revision with dropped
>> > experimental sidebar api.
>>
>> >  Can I get the last revision no from somewhere, before the code was
>> > removed?
>

> --
> You received this message because you are subscribed to the Google Groups "Chromium-extensions" group.
> To post to this group, send email to chromium-...@chromium.org.
> To unsubscribe from this group, send email to chromium-extens...@chromium.org.
> For more options, visit this group at http://groups.google.com/a/chromium.org/group/chromium-extensions/?hl=en.
>

trappedIntoCode

unread,
Mar 11, 2012, 1:56:29 PM3/11/12
to Chromium-extensions
I think my last post went to Adam, was sent from mobile. Apologies.

thanks. So I will have to take ideas from old code, style/api guide
from something like infobars and work my way.

On Mar 11, 10:14 pm, Adam Barth <aba...@chromium.org> wrote:
> On Sun, Mar 11, 2012 at 9:49 AM, trappedIntoCode
>
> > To post to this group, send email to chromium-extensi...@chromium.org.
> > To unsubscribe from this group, send email to chromium-extensions+unsubscr...@chromium.org.

Adam Barth

unread,
Mar 11, 2012, 2:18:47 PM3/11/12
to trappedIntoCode, Chromium-extensions
Are you planning to contribute your patch to trunk? If so, you might
want to check whether the patch will be accepted before you go to too
much trouble. (I suspect that there's a strong chance that the patch
won't be accepted, by the way.)

If you're not planning to contribute your patch back to trunk, there's
no need to worry about such things, of course.

Adam

> To post to this group, send email to chromium-...@chromium.org.
> To unsubscribe from this group, send email to chromium-extens...@chromium.org.

trappedIntoCode

unread,
Mar 11, 2012, 2:40:10 PM3/11/12
to Chromium-extensions
well, I will be happy to contribute the patch when I get it working,
but I gathered
from the previous code reviews and issues, sidebar is on much low
priority, UI team
had some objections on design and there wasn't an active committer
working on it ..
so it was taken down, I may be wrong.

I am working on this for a client who absolutely needs a sidebar on
chrome on Windows,
so I will be doing it anyway.

I will try and submit if there is any chance, or if I come up with "a
cool demo
that wins the team over."
(demo bit reference: https://groups.google.com/a/chromium.org/group/chromium-dev/msg/7d42fbbf8eedc483)

Thanks.

Pratik.

trappedIntoCode

unread,
Mar 11, 2012, 3:45:26 PM3/11/12
to Chromium-extensions
From another angle, are there things I should consider/take care of
from beginning to increase
the chances of getting patch accepted?

- Pratik.

On Mar 11, 11:40 pm, trappedIntoCode <trapped.into.c...@gmail.com>
wrote:
> well, I will be happy to contribute the patch when I get it working,
> but I gathered
> from the previous code reviews and issues, sidebar is on much low
> priority, UI team
> had some objections on design and there wasn't an active committer
> working on it ..
> so it was taken down, I may be wrong.
>
> I am working on this for a client who absolutely needs a sidebar on
> chrome on Windows,
> so I will be doing it anyway.
>
> I will try and  submit if there is any chance, or if I come up with "a
> cool demo
> that wins the team over."
> (demo bit reference:https://groups.google.com/a/chromium.org/group/chromium-dev/msg/7d42f...)

Adam Barth

unread,
Mar 11, 2012, 4:21:31 PM3/11/12
to trappedIntoCode, Chromium-extensions
Generally, Brett's advice in
https://groups.google.com/a/chromium.org/group/chromium-dev/msg/7d42fbbf8eedc483
is probably pretty reasonable.

It's hard to find folks who've become successful members of the
community by starting out implementing a big new feature. Folks tend
to be more successful when they start by fixing bugs, becoming
familiar with the codebase and the community, and then start to
understand/influence the direction of the project.

For sidebars, in particular, my understanding is that we removed them
from the product because we neither liked the way the code was written
nor the user experience of sidebars themselves. From the starting
point, it unlikely that the project would accept a new sidebar
implementation without both significant changes in the implementation
and the user experience.

Adam

> To post to this group, send email to chromium-...@chromium.org.
> To unsubscribe from this group, send email to chromium-extens...@chromium.org.

trappedIntoCode

unread,
Mar 11, 2012, 4:57:42 PM3/11/12
to Chromium-extensions
yes, I understand.

I will try submitting a patch anyway if/when I get it working.
Hopefully we will find a way
to work on design and standards to make it acceptable. Chrome IS
probably
the only browser without persistent sidebar support, and there are
many application of it
for social and collaborative extensions. For me, it will not be wasted
efforts, I have to work on it
anyway.

Thanks.

Pratik.


On Mar 12, 1:21 am, Adam Barth <aba...@chromium.org> wrote:
> Generally, Brett's advice inhttps://groups.google.com/a/chromium.org/group/chromium-dev/msg/7d42f...

Devin

unread,
Mar 12, 2012, 2:04:58 PM3/12/12
to Chromium-extensions
I love your attitude Pratik! I would die for a literal sidebar API, I
don't know C++, but I can help in whatever way possible!

-Devin


On Mar 11, 1:57 pm, trappedIntoCode <trapped.into.c...@gmail.com>
wrote:

Devin

unread,
Mar 12, 2012, 2:13:34 PM3/12/12
to Chromium-extensions
I remember seeing diagrams and such on the application structure...
hopefully you can find these

trappedIntoCode

unread,
Mar 12, 2012, 9:19:11 PM3/12/12
to Chromium-extensions
> > I love your attitude Pratik! I would die for a literal sidebar API,

oh "cool demo" was Brett's idea...I do think it may actually need much
more than that to do the trick.

-Pratik.

Ben McCann

unread,
Nov 18, 2013, 2:50:11 PM11/18/13
to chromium-...@chromium.org
Hi,

I filed a bug requesting a sidebar extension API for Chrome. There are quite a few stars already and some folks from Google are deciding how to triage the issue. Please star the issue to show your support and be notified of any changes.

-Ben
Reply all
Reply to author
Forward
0 new messages