Restricting use of file: URLs in tabs and windows APIs

ยอดดู 11,611 ครั้ง
ข้ามไปที่ข้อความที่ยังไม่อ่านรายการแรก

Jun Kokatsu

ยังไม่อ่าน,
10 ส.ค. 2566 14:00:0410/8/66
ถึง Chromium Extensions

Chromium extensions are currently allowed to navigate to file URLs through chrome.tabs and chrome.windows APIs. However, most extensions do not use these, and they can sometimes introduce a vulnerability where an extension unexpectedly navigates to a file URL of an attacker’s choice. This can result in a number of issues, such as local file disclosure.


Following discussions in the WECG, we plan to restrict navigation to file URLs (in Chromium 118), unless the “Allow access to file URLs” option is enabled on the extension’s details page. The use of navigation to file URLs is low in Chrome (approximately 0.02%), and we expect that for most extensions there will be no impact. In the small number of other cases, we believe that the toggle is a reasonable requirement.


Firefox already restricts file URLs, and Safari supports the change.


Along similar lines, we recently landed a change to expand restrictions on javascript URLs to all API methods. This was already blocked for tabs.update, and opening these URLs outside of an existing tab has limited use. This will land in 117 and we do not expect any impact.


As always, please do let us know if you have any feedback.


Thanks,


Jun on behalf of Chrome Extension team


Don Schmitt

ยังไม่อ่าน,
16 ก.ย. 2566 19:00:4716/9/66
ถึง Jun Kokatsu, Chromium Extensions
Hi,

I believe you should provide a Group Policy to enable this enterprise wide.  We have customers who have tools that download files that they then open locally with our extension as a viewer.  Can you provide a policy for this?

Thanks!
Don



--
You received this message because you are subscribed to the Google Groups "Chromium Extensions" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-extens...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-extensions/c9085e6f-d021-4516-93bd-61f360898b0en%40chromium.org.

Patrick Kettner

ยังไม่อ่าน,
27 ก.ย. 2566 15:31:1227/9/66
ถึง Don Schmitt, Jun Kokatsu, Chromium Extensions
Hey Don
Do you mean an enterprise policy to not restrict the use of file URLs in extensions?

Don Schmitt

ยังไม่อ่าน,
27 ก.ย. 2566 15:47:1827/9/66
ถึง Patrick Kettner, Jun Kokatsu, Chromium Extensions
Hi Patrick,

Allow me to clarify.  If I understand this change announcement, this change makes it so that an extension cannot navigate to a file URL unless the following permission has been enabled on the extension page for that extension:  "Allow access to file URLs” .  However, unless something has changed there is no way to enable that option with enterprise policy for an extension and it's impractical for an enterprise to have their end users manually change settings.

The lack of ability to enable this option has come up in the past and I don't recall what the resistance was to providing enterprise policy for enabling that option.  I think perhaps it was difficult before there was an ExtensionSettings policy (i.e. the ability to set per-extension values).

Does that make sense?

--
Don


Jun Kokatsu

ยังไม่อ่าน,
29 ก.ย. 2566 13:37:0429/9/66
ถึง Chromium Extensions, Don Schmitt, Jun Kokatsu, Chromium Extensions, Patrick Kettner
Hi Don!

Sorry it took sometime to get back on this.
I've added a new field in ExtensionSettings policy to allow navigation to file URLs from configured extensions.
Unfortunately, this policy change will not land in time for Chrome 118. Meanwhile, you can disable the RestrictFileURLNavigation feature.

Hope this helps!

Jun

Don Schmitt

ยังไม่อ่าน,
30 ก.ย. 2566 11:38:3630/9/66
ถึง Jun Kokatsu, Chromium Extensions, Patrick Kettner
Wow, what a quick response.  Great work, thank you!


David

ยังไม่อ่าน,
2 ต.ค. 2566 12:10:252/10/66
ถึง Chromium Extensions, Don Schmitt, Chromium Extensions, Patrick Kettner, Jun Kokatsu
Hi Jun,

I tried to test this new feature on the latest Chrome Canary.
The policy loaded and the schema was validated correctly. The extension is force-installed by the enterprise.
I expected the "Allow access to file URLs" to be enabled once I did it but there was no change.

How should I test it?
Tried running chrome.extension.isAllowedFileSchemeAccess as well to verify.

Our enterprise has a self-hosted extension installed on enterprise enrolled devices, and we wish to allow access to file URLs without user intervention.

Thanks.

Jun Kokatsu

ยังไม่อ่าน,
2 ต.ค. 2566 18:33:192/10/66
ถึง David, Chromium Extensions, Don Schmitt, Patrick Kettner
Hi David,

The new enterprise policy does not allow access to file URLs. It just allows navigation to file URLs from specified extensions, which is being deprecated in Chrome 118.

Thanks,

Jun

iza

ยังไม่อ่าน,
15 ต.ค. 2566 00:08:0115/10/66
ถึง Chromium Extensions, Jun Kokatsu, Chromium Extensions
Hi, I'm the developer of Humble New Tab Page.
Some of my users have bookmarks to local files, and have complained that they can no longer open them from my extension new tab page.

Am I correct in understanding that for the "Allow access to file URLs" toggle to show up for my extension, I would need to declare
"host_permissions": ["file:///*"] in my extension manifest? Because I really don't want or need such a broad permission. Is there no way to request navigation permission without full read access?

iza

ยังไม่อ่าน,
15 ต.ค. 2566 00:54:5315/10/66
ถึง Chromium Extensions, iza, Jun Kokatsu, Chromium Extensions
On further investigation, it looks like I can add the "activeTab" permission instead to make the "Allow access to file URLs" toggle available. Still an unnecessary permission for my extension, but less invasive.

Jackie Han

ยังไม่อ่าน,
16 ต.ค. 2566 04:02:1416/10/66
ถึง Jun Kokatsu, Chromium Extensions, iza
Hi Jun Kokatsu,

I noticed that there is no "Allow access to file URLs" option for my extensions from Web Store, but there is this option for all unpacked extensions.

Screenshot 2023-10-16 at 15.55.38.png
Above screenshot is an extension from Web Store. There is no "Allow access to file URLs" option!

Screenshot 2023-10-16 at 15.56.07.png
Above screenshot is an unpacked extension. All unpacked extensions have this option.

So how can users enable "Allow access to file URLs" for extensions installed from CWS?


Jackie Han

ยังไม่อ่าน,
16 ต.ค. 2566 04:09:2916/10/66
ถึง iza, Chromium Extensions, Jun Kokatsu
Hi, iza

For unpacked extension, just enable "Allow access to file URLs", it works. It doesn't need any permissions (like "file:///*" or "activeTab"). But extensions from CWS don't show this option. That is a problem.

Flozzl 51

ยังไม่อ่าน,
16 ต.ค. 2566 06:02:1416/10/66
ถึง Chromium Extensions, Jackie Han, Chromium Extensions, Jun Kokatsu, iza
Hi,
ive tried the solution but somehow "file_url_navigation" is not working for the extension " Enable local file links". 


Screenshot 2023-10-16 115314.jpg

This is how its configured in GPO

Screenshot 2023-10-16 120040.jpg

Here you can see that only the Pin to toolbar command is working.
Am i doing something wrong here?

Jun Kokatsu

ยังไม่อ่าน,
16 ต.ค. 2566 14:32:1616/10/66
ถึง Chromium Extensions, Flozzl 51, Jackie Han, Chromium Extensions, Jun Kokatsu, iza
Hi All!

To iza and Jackie, I think requesting "file:///*" permission is the best option here, as it does not provide file access to the extension until users enable the "allow access to file URLs" option.
The reason why we didn't expose new toggle specific to file URL navigations is that we think normal users wouldn't understand what navigation to file URLs mean in terms of granting access. Therefore, we wanted to tie navigation to file URLs with the file URL access itself, which seems more clearer.

To Flozzl 51, unfortunately, the request for enterprise policy came a month after we announced the change, and therefore it didn't land on time for Chrome 118. But it will be available from Chrome 119.

Thanks,

Jun

iza

ยังไม่อ่าน,
16 ต.ค. 2566 14:58:0916/10/66
ถึง Chromium Extensions, Jun Kokatsu, Jackie Han, Chromium Extensions, iza
I ended up adding "optional_host_permissions": [ "file:///*" ]
This way the "Allow access to file URLs" is shown, navigation works, but I don't actually get read permission.

Jun Kokatsu

ยังไม่อ่าน,
16 ต.ค. 2566 15:11:3116/10/66
ถึง Chromium Extensions, iza, Jun Kokatsu, Jackie Han, Chromium Extensions
That's amazing iza! Thank you for sharing your tips!

Jun

Jackie Han

ยังไม่อ่าน,
17 ต.ค. 2566 01:12:1517/10/66
ถึง Jun Kokatsu, Chromium Extensions, iza
Great! I just published a new version of my extension which added the "optional_host_permissions": [ "file:///*" ] in manifest. After upgrading from CWS, the extension details page shows the "Allow access to file URLs" option now.

Although this solves the problem, I think many people don't know this difference between unpacked extensions and packed extensions from CWS.

MH

ยังไม่อ่าน,
20 ต.ค. 2566 06:45:4820/10/66
ถึง Chromium Extensions, Jackie Han, Chromium Extensions, iza, Jun Kokatsu
Hello

I have tested the new policy with chrome 119 beta:
The Registrykey ("file_url_navigation_allowed"=dword:00000001) seems to be valid, but the behevior has not changed.
Is it true, that its still necessary to enable the file access in the extension settings?
If so, how can I force this settings without user interaction. (Company with ~6k employees)?

Thanks for your respond.

Jun Kokatsu

ยังไม่อ่าน,
20 ต.ค. 2566 20:30:2320/10/66
ถึง MH, Chromium Extensions, Jackie Han, iza
Hi,

Unfortunately, I currently don't have access to windows PC to verify this issue.
But I think it is not working because you have not set the extension ID. Since file_url_navigation_allowed is a part of the ExtensionSettings policy, you'd need to set the extension ID for which you want to allow file: URL navigation.
I can try to repro this next week if you still see the same issue.

Thanks,

Jun

MH

ยังไม่อ่าน,
26 ต.ค. 2566 02:42:1926/10/66
ถึง Chromium Extensions, Jun Kokatsu, Chromium Extensions, Jackie Han, iza, MH
Hi Jun

I think i did it correctly, this is what it shows in chrome://policy (valid):

{
  "nikfmfgobenbhmocjaaboihbeocackld": {
    "file_url_navigation_allowed": true,
    "installation_mode": "force_installed",
    "update_url": "file:////[Path to xml]//ChromeExtensions.xml"
  }
}


Still have the same issue.
Thanks

Jun Kokatsu

ยังไม่อ่าน,
30 ต.ค. 2566 20:26:0430/10/66
ถึง Chromium Extensions, MH, Jun Kokatsu, Chromium Extensions, Jackie Han, iza
Hi,

I was successfully able to apply `file_url_navigation_allowed` on Chrome Beta for Windows.
I followed these steps to download and apply Admin template. This guide from Edge actually goes more details into how to make a JSON to apply to ExtensionSettings policy, but I basically applied `{"hinmcgipjjndkedddmmpidnjikjebejj":{"file_url_navigation_allowed":true}}` and it worked. Make sure that Chrome is restarted and the policy changes appears in chrome://policy.

Thanks,

Jun

ELU Konsult

ยังไม่อ่าน,
31 ต.ค. 2566 03:50:0331/10/66
ถึง Chromium Extensions, Jun Kokatsu, MH, Chromium Extensions, Jackie Han, iza
I have tried both Chrome Beta (version 119.0.6045.59) and Edge for Business Beta (119.0.2151.38) and i can't get the policy 'file_url_navigation_allowed' to work.

This is what i have in my Group policy setting "Extension management settings":
{"nikfmfgobenbhmocjaaboihbeocackld":{"file_url_navigation_allowed":true}}

In Chrome Beta i get no Policy error, but the policy does not Enable "Allow access to file URLs".
In Edge for Business Beta i get a Policy error: " ErrorError at ExtensionSettings.nikfmfgobenbhmocjaaboihbeocackld: Schema validation error: Unknown property: file_url_navigation_allowed"

Am i doing something wrong?
Edge_beta.png
Chrome_Beta_Plugin.png
Chrome_Beta_Policy.png
Chrome_Beta.png
Edge_Beta_policy_Error.png
GPO.png

Jun Kokatsu

ยังไม่อ่าน,
31 ต.ค. 2566 12:49:5931/10/66
ถึง Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Chromium Extensions, Jackie Han, iza
Hi,

The policy addition for each release channel can be checked here.
On Chrome Beta, it starts support from 119.0.6045.9 onwards, which is probably why it did not work on your version (i.e. 119.0.6045.59).

Please try on version 119.0.6045.9 or up and let me know if it works!

Thanks,

Jun

ELU Konsult

ยังไม่อ่าน,
1 พ.ย. 2566 04:27:031/11/66
ถึง Chromium Extensions, Jun Kokatsu, ELU Konsult, MH, Chromium Extensions, Jackie Han, iza
Hello Jun,

I have tried the latest beta build " Version 119.0.6045.105 (Official Build) beta (64-bit)" and the issue still is the same.
The policy does not have any effect on enabling "Allow access to file URLs"

Also tried downloading the Chrome Canary version of the browser, but it doesn't work in that either.
This is the JSON value from Chrome policy page: 
{ "nikfmfgobenbhmocjaaboihbeocackld": { "file_url_navigation_allowed": true } }
Chrome_Beta_6045.105.png
Chrome_Beta_Policy_105.png

Flozzl 51

ยังไม่อ่าน,
1 พ.ย. 2566 05:50:321/11/66
ถึง Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Chromium Extensions, Jackie Han, iza
Hi,

same preconditions and problems like @ELU_Konsult .
Policy have been set and i have the newest version ( 119.0.6045.106).

Oliver Dunk

ยังไม่อ่าน,
1 พ.ย. 2566 06:48:381/11/66
ถึง Flozzl 51, Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Jackie Han, iza
Hi both,

My understanding is that this does not affect the "Allow access to file URL" toggle, and only impacts the ability to navigate to file:// URLs using the different APIs.

Have you tried to use those APIs since applying the policy?

Thanks,
Oliver Dunk | DevRel, Chrome Extensions | https://developer.chrome.com/ | London, GB


Flozzl 51

ยังไม่อ่าน,
1 พ.ย. 2566 08:37:251/11/66
ถึง Chromium Extensions, Oliver Dunk, Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Jackie Han, iza, Flozzl 51
We are using the same APIs since a very long time

Oliver Dunk

ยังไม่อ่าน,
1 พ.ย. 2566 08:39:291/11/66
ถึง Flozzl 51, Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Jackie Han, iza
Can you confirm the code that you are running and what error messaging you are getting with this policy applied?
Oliver Dunk | DevRel, Chrome Extensions | https://developer.chrome.com/ | London, GB

Flozzl 51

ยังไม่อ่าน,
1 พ.ย. 2566 08:47:521/11/66
ถึง Chromium Extensions, Oliver Dunk, Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Jackie Han, iza, Flozzl 51
Sorry, what do you want me to do?
The policy is active but its not working. 

Screenshot 2023-11-01 134630.jpg

Oliver Dunk

ยังไม่อ่าน,
1 พ.ย. 2566 09:16:291/11/66
ถึง Flozzl 51, Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Jackie Han, iza
Could you share:
  • The code you are running to test if this is working (just the snippet navigating to a file:// URL is ok)
  • What error message you see when this fails to work
Thanks,
Oliver Dunk | DevRel, Chrome Extensions | https://developer.chrome.com/ | London, GB

Flozzl 51

ยังไม่อ่าน,
1 พ.ย. 2566 09:28:571/11/66
ถึง Chromium Extensions, Oliver Dunk, Chromium Extensions, ELU Konsult, Jun Kokatsu, MH, Jackie Han, iza, Flozzl 51
For example : file://ourdomain.local/file.pdf
Then a new site opens "chrome-extension://nikfmfgobenbhmocjaaboihbeocackld/options/index.html#need-file-scheme-access"

This is what you need?
Screenshot 2023-11-01 142756.jpg

Oliver Dunk

ยังไม่อ่าน,
1 พ.ย. 2566 09:38:301/11/66