Request to implement a feature.

178 views
Skip to first unread message

SHREY PATEL

unread,
Sep 20, 2023, 5:47:28 PM9/20/23
to Chromium-discuss
When opening video/audio with chrome. It wont accept any arrow keys control (ie. skip 10s on right arrow key and  vice versa, similarly for volume control).

I have made the necessary changes to the code should I commit?

you can recreate what I am lacking
by:
Screenshot 2023-09-15 013032.png

any type of discussions are appreciated.

thanks,

PhistucK

unread,
Sep 20, 2023, 5:54:25 PM9/20/23
to shrey1...@gmail.com, Chromium-discuss
Welcome :)

PhistucK


--
--
Chromium Discussion mailing list: chromium...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-discuss

---
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-discu...@chromium.org.

SHREY PATEL

unread,
Sep 20, 2023, 8:55:47 PM9/20/23
to Chromium-discuss, PhistucK, Chromium-discuss, shrey1...@gmail.com
Thanks for the help. 
Is it necessary to write tests for this functionality? If yes, could you provide some references or any assistance?

PhistucK

unread,
Sep 21, 2023, 6:20:39 AM9/21/23
to SHREY PATEL, Chromium-discuss
Before you put too much time into it, I would upload the change to Gerrit first (git cl upload) and get some eyes on the change.
If they are fine with the feature itself, then go about writing tests maybe. You can also get some advice from the reviewer on where the tests should reside this way.

PhistucK

SHREY PATEL

unread,
Sep 21, 2023, 4:46:07 PM9/21/23
to Chromium-discuss, PhistucK, Chromium-discuss, SHREY PATEL
thanks for guidance ill do the same
Reply all
Reply to author
Forward
0 new messages