Ressouces modifications

23 views
Skip to first unread message

gabri...@thomsonreuters.com

unread,
May 10, 2012, 9:40:05 AM5/10/12
to Chromium-discuss
Hello

I'm working for Thomson Reuters and our product Eikon, will soon
integrate Chromium to perform built in navigation.
This is why we have now a custom built of Chromium shipped with our
product.

The integration have been done with Chrome Frame.

There are still some points that requires a modification every time we
integrate a new version of Chromium.

For the example the string
"He is dead Jim"
is not exactly seen as professional. We have other message that
demonstrate a very enthusiastic spirit but at the same time feel out
of tone in a pro environment.

This is why I would like to know if there is a way to provide
alternate resources, without having to perform a grep + replace in all
the source code.

Regards

Gabriel Vey

Joao da Silva

unread,
May 10, 2012, 10:10:13 AM5/10/12
to gabri...@thomsonreuters.com, Chromium-discuss
Most of the user-visible strings are defined in src/chrome/app/generated_resources.grd. Search for IDS_KILLED_TAB_TITLE for the "dead, Jim" string.

- Joao
 

Regards

Gabriel Vey

--
Chromium Discussion mailing list: chromium...@chromium.org
View archives, change email options, or unsubscribe:
   http://groups.google.com/a/chromium.org/group/chromium-discuss

Sailesh Agrawal

unread,
May 10, 2012, 8:12:02 PM5/10/12
to gabri...@thomsonreuters.com, Chromium-discuss, mars...@chromium.org
Hi Gabriel.

marshall@ recently made changes to the resource loading code so that
embedding clients can customize strings. Simple implement a
ResourceBundle delegate and return a different value for strings you
want customized and NULl for strings you don't want to customize.

See: http://code.google.com/p/chromium/issues/detail?id=125351

Thanks,
Sailesh

gabri...@thomsonreuters.com

unread,
May 11, 2012, 5:14:08 AM5/11/12
to chromium...@chromium.org, gabri...@thomsonreuters.com
Thanks Joao !

This is what we do currently, but this requires a modification of the source code, and an additional step every time we integrate a new version of Chrome.

Regards

Gabriel


Le jeudi 10 mai 2012 16:10:13 UTC+2, Joao da Silva a écrit :
On Thu, May 10, 2012 at 3:40 PM, 
wrote:

gabri...@thomsonreuters.com

unread,
May 11, 2012, 5:16:29 AM5/11/12
to chromium...@chromium.org, gabri...@thomsonreuters.com, mars...@chromium.org
Thanks Sailesh

This looks most promising.
We will investigate this solution.

Regards
Gabriel



Le vendredi 11 mai 2012 02:12:02 UTC+2, Sailesh Agrawal a écrit :
Hi Gabriel.

marshall@ recently made changes to the resource loading code so that
embedding clients can customize strings. Simple implement a
ResourceBundle delegate and return a different value for strings you
want customized and NULl for strings you don't want to customize.

See: http://code.google.com/p/chromium/issues/detail?id=125351

Thanks,
Sailesh

Reply all
Reply to author
Forward
0 new messages