Please wait with Chrome 53 auto update - Regex compat issues

464 views
Skip to first unread message

Omri Feldbau

unread,
Sep 1, 2016, 3:52:51 PM9/1/16
to Chromium-discuss
Hi Chromium guys,

i'm an R&D manager from a 888.com
Surprisingly, we discovered today that many of our validations using "pattern" attribute regex's are not working.

This causes our registration forms to be unusable.

What we have found out is that UTF16 encoding is now enforced on patterns and it is more strict than before.

Meaning patterns like that :

Not Valid - ^[A-Za-zÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÑÒÓÔÕÖØÙÚÛÜßàáâãäåæçèéêëìíîïñòóôõöøùúûüĂ㪺ŢţȚțȘșŸÿŠš\s-',]{2,30}$ -

Example for Valid pattern(now needs an escaping on the minus sign.): ^[A-Za-zÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÑÒÓÔÕÖØÙÚÛÜßàáâãäåæçèéêëìíîïñòóôõöøùúûüĂ㪺ŢţȚțȘșŸÿŠš\s-',]{2,30}$

 

Another example:

Not valid - ^([a-zA-Z0-9_\-])+([a-zA-Z0-9_\.\-])*\@(([a-zA-Z0-9\-])+\.)+([a-zA-Z0-9]{2,4})$

Valid (remove escaping from the @ sign) - ^([a-zA-Z0-9_\-])+([a-zA-Z0-9_\.\-])*@(([a-zA-Z0-9\-])+\.)+([a-zA-Z0-9]{2,4})$

  

This is caused by the issue discussed in the following thread:
https://bugs.chromium.org/p/chromium/issues/detail?id=535441


can you please wait with the Auto Update? or the best -revert this change?

Thanks,

Omri

PhistucK

unread,
Sep 1, 2016, 4:06:40 PM9/1/16
to omr...@gmail.com, Chromium-discuss
​This is an intentional change. The usage of pattern with invalid patterns (after the change) was ​very low and it was therefore changed. This is per the specification and Firefox also ships it in Firefox 49 (coming up in September).

I am sorry about the lack of advance notice (other than the Chrome 53 beta blog post, the intent to ship thread and the chromestatus.com entry). I do recommend that you test with beta releases (or subscribe to the Chromium blog) in order to prepare for such intentional changes, though. Those changes are usually not reverted (or updates held back) due to a single broken website, regardless of its popularity.

I think it should be an easy fix for you (remove invalid escapes). You might even be able to automate it.

(Also note that your first example does not have any difference between the original and the corrected regular expressions)


PhistucK

--
--
Chromium Discussion mailing list: chromium...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-discuss

---
You received this message because you are subscribed to the Google Groups "Chromium-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-discuss+unsubscribe@chromium.org.

Primiano Tucci

unread,
Sep 1, 2016, 4:14:02 PM9/1/16
to omr...@gmail.com, Chromium-discuss
Can you please file a bug on crbug.com? The best place to discuss and eventually block a release is the bug tracker.

Reply all
Reply to author
Forward
0 new messages