PSA: Auto-Submit for chromium/src coming soon

84 views
Skip to first unread message

rmi...@chromium.org

unread,
Jan 15, 2019, 8:26:21 AM1/15/19
to Chromium-dev


If you do not use Gerrit to upload or review CLs for chromium/src, you can stop reading now.



In a couple of days we will enable the Auto-Submit feature for the chromium/src repo in Gerrit. As a CL owner (aka first uploader), you can ask Gerrit to automatically CQ+2 the CL after passing codereview (CR+1).


This can be done in 2 ways:

  • git cl upload -a|--enable-auto-submit

  • Vote Auto-Submit+1 in Gerrit UI


Then, Gerrit will:

  • Automatically set CQ+2 (with an info msg) when CR+1 is selected in the reply dialog.

  • Ask reviewer if CQ+2 should automatically be set when using the "CodeReview+1" quick approve button on the main page.

  • If there are any unresolved comments and/or drafts then it will suppress Auto-Submit in the reply dialog.


Bonus feature:

  • The “CodeReview+1” quick approve button used to disappear when another reviewer gave their CR+1. But now it will stick around till your CR+1.


Auto-Submit for PolyGerrit is yet another result of collaboration across team boundaries. The feature owner is rmistry@ (Skia team), agable@ helped design the UX (ChOps), and viktard@ helped with consultation for Gerrit plugins (PolyGerrit).


Auto-Submit has already been successfully used 1500+ times by the Skia team, and 750+ times by infra repositories. So we think you will enjoy it, too.


Please file a crbug with the Infra>Codereview>Gerrit component if you find any bugs or have feature requests.



Thanks,

Ravi


rmi...@chromium.org

unread,
Jan 17, 2019, 9:46:56 AM1/17/19
to Chromium-dev
Update: The Auto-Submit feature has been enabled for chromium/src.
Please file a crbug with the Infra>Codereview>Gerrit component if you find any bugs or have feature requests.

Thanks,
Ravi
Reply all
Reply to author
Forward
0 new messages