113.0.5672.132 branch build error

[Zelong Gong]

zelong@zelong-ThinkPad-T430:/home/sdb/chromium/src$ autoninja -C out/Default cast_shell_apk
ninja: Entering directory `out/Default'
[1/23] SOLINK ./libcast_shell_android.cr.so
FAILED: libcast_shell_android.cr.so libcast_shell_android.cr.so.TOC lib.unstripped/libcast_shell_android.cr.so
python3 "../../build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/llvm-build/Release+Asserts/bin/llvm-readelf" --nm="../../third_party/llvm-build/Release+Asserts/bin/llvm-nm" --strip=../../third_party/llvm-build/Release+Asserts/bin/llvm-strip  --sofile="./lib.unstripped/libcast_shell_android.cr.so" --tocfile="./libcast_shell_android.cr.so.TOC" --output="./libcast_shell_android.cr.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libcast_shell_android.cr.so" -Wl,-z,muldefs -Werror -fuse-ld=lld -Wl,--fatal-warnings -Wl,--build-id -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,--color-diagnostics -Wl,--no-rosegment -Wl,--undefined-version -Wl,--no-call-graph-profile-sort -Wl,--exclude-libs=libvpx_assembly_arm.a --unwindlib=none --target=arm-linux-androideabi24 -no-canonical-prefixes -Wl,-z,defs -Wl,--as-needed -nostdlib++ --sysroot=../../third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -Wl,-wrap,calloc -Wl,-wrap,free -Wl,-wrap,malloc -Wl,-wrap,memalign -Wl,-wrap,posix_memalign -Wl,-wrap,pvalloc -Wl,-wrap,realloc -Wl,-wrap,valloc -Wl,-wrap,malloc_usable_size -Wl,-wrap,realpath -Wl,-wrap,strdup -Wl,-wrap,strndup -Wl,-wrap,getcwd -Wl,-wrap,asprintf -Wl,-wrap,vasprintf -Wl,--dynamic-linker,/system/bin/linker -o "./lib.unstripped/libcast_shell_android.cr.so" @"./libcast_shell_android.cr.so.rsp"  
ld.lld: error: undefined symbol: chromecast::GraphicsPropertiesShlib::IsSupported(chromecast::GraphicsPropertiesShlib::Resolution, std::Cr::vector<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::allocator<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>> const&)
>>> referenced by cast_display_configurator.cc:41 (../../chromecast/browser/cast_display_configurator.cc:41)
>>>               obj/chromecast/browser/display_configurator/cast_display_configurator.o:(chromecast::shell::CastDisplayConfigurator::ConfigureDisplayFromCommandLine())

ld.lld: error: undefined symbol: chromecast::GetDeviceScaleFactor(gfx::Size const&)
>>> referenced by cast_display_configurator.cc:166 (../../chromecast/browser/cast_display_configurator.cc:166)
>>>               obj/chromecast/browser/display_configurator/cast_display_configurator.o:(chromecast::shell::CastDisplayConfigurator::ConfigureDisplayFromCommandLine())
>>> referenced by cast_display_configurator.cc:229 (../../chromecast/browser/cast_display_configurator.cc:229)
>>>               obj/chromecast/browser/display_configurator/cast_display_configurator.o:(chromecast::shell::CastDisplayConfigurator::OnDisplaysAcquired(bool, std::Cr::vector<display::DisplaySnapshot*, std::Cr::allocator<display::DisplaySnapshot*>> const&))
>>> referenced by cast_display_configurator.cc:272 (../../chromecast/browser/cast_display_configurator.cc:272)
>>>               obj/chromecast/browser/display_configurator/cast_display_configurator.o:(chromecast::shell::CastDisplayConfigurator::OnDisplayConfigured(display::DisplaySnapshot*, display::DisplayMode const*, gfx::Point const&, bool))

ld.lld: error: undefined symbol: chromecast::CastScreen::OnDisplayChanged(long long, float, display::Display::Rotation, gfx::Rect const&)
>>> referenced by cast_display_configurator.cc:284 (../../chromecast/browser/cast_display_configurator.cc:284)
>>>               obj/chromecast/browser/display_configurator/cast_display_configurator.o:(chromecast::shell::CastDisplayConfigurator::UpdateScreen(long long, gfx::Rect const&, float, display::Display::Rotation))

ld.lld: error: undefined symbol: Java_org_chromium_base_natives_GEN_1JNI_org_1chromium_1ui_1base_1SelectFileDialog_1onFileSelected
>>> referenced by cast_jni_loader.cc
>>>               obj/chromecast/android/libcast_shell_android/cast_jni_loader.o:(kMethods_org_chromium_base_natives_GEN_1JNI)

ld.lld: error: undefined symbol: Java_org_chromium_base_natives_GEN_1JNI_org_1chromium_1ui_1base_1SelectFileDialog_1onMultipleFilesSelected
>>> referenced by cast_jni_loader.cc
>>>               obj/chromecast/android/libcast_shell_android/cast_jni_loader.o:(kMethods_org_chromium_base_natives_GEN_1JNI)

ld.lld: error: undefined symbol: Java_org_chromium_base_natives_GEN_1JNI_org_1chromium_1ui_1base_1SelectFileDialog_1onFileNotSelected
>>> referenced by cast_jni_loader.cc
>>>               obj/chromecast/android/libcast_shell_android/cast_jni_loader.o:(kMethods_org_chromium_base_natives_GEN_1JNI)

ld.lld: error: undefined symbol: Java_org_chromium_base_natives_GEN_1JNI_org_1chromium_1ui_1base_1SelectFileDialog_1onContactsSelected
>>> referenced by cast_jni_loader.cc
>>>               obj/chromecast/android/libcast_shell_android/cast_jni_loader.o:(kMethods_org_chromium_base_natives_GEN_1JNI)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.


Anyone knows how to fix it?


To fix other errors on this branch, here is my local changes.

git log -p

commit 9c5e7153fca61e3a3c71f7113e2aefa7d06921eb (HEAD -> 113.0.5672.132)
Author: gongzelong <gongz...@gmail.com>
Date:   Wed May 31 20:12:34 2023 +0800

    patch2

diff --git a/ui/shell_dialogs/select_file_dialog_android.cc b/ui/shell_dialogs/select_file_dialog_android.cc
index 4b2b8932d9583..b300b5a54055f 100644
--- a/ui/shell_dialogs/select_file_dialog_android.cc
+++ b/ui/shell_dialogs/select_file_dialog_android.cc
@@ -160,10 +160,12 @@ bool SelectFileDialogImpl::HasMultipleFileTypeChoicesImpl() {
   return false;
 }
 
+#if 0
 SelectFileDialog* CreateSelectFileDialog(
     SelectFileDialog::Listener* listener,
     std::unique_ptr<SelectFilePolicy> policy) {
   return SelectFileDialogImpl::Create(listener, std::move(policy));
 }
++#endif
 
 }  // namespace ui

commit 6e3c45cfc0573e90b60cc5c697f8e1a5e90df192
Author: gongzelong <gongz...@gmail.com>
Date:   Wed May 31 20:12:10 2023 +0800

    patch1

diff --git a/ui/shell_dialogs/BUILD.gn b/ui/shell_dialogs/BUILD.gn
index 08e4d5b5b7630..a66b14e7bf862 100644
--- a/ui/shell_dialogs/BUILD.gn
+++ b/ui/shell_dialogs/BUILD.gn
@@ -99,7 +99,8 @@ component("shell_dialogs") {
     deps += [ "//ui/aura" ]
   }
 
-  if (is_android) {
+  ## if (is_android) {
+  if (is_android && !is_cast_android) {
     sources += [
       "select_file_dialog_android.cc",
       "select_file_dialog_android.h",

commit 8b15c50a2d5b5a112d8b14948dbd4a00cd59d015 (tag: 113.0.5672.132)
Author: Chrome Release Bot (LUCI) <chrome-offic...@chops-service-accounts.iam.gserviceaccount.com>
Date:   Mon May 15 17:59:56 2023 +0000

    Publish DEPS for 113.0.5672.132