buildbot failure in Chromium on Vista Tests, revision 39588

[buil...@chromium.org]

http://build.chromium.org/buildbot/waterfall/

Automatically closing tree for "unit_tests" on "Vista Tests"

http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/16280

Revision: 39588
Blame list: tha...@chromium.org

Vista Tests Build 16280

svnkill stdio

update scripts stdio

taskkill stdio

update stdio

extract build stdio

Start Crash Handler stdio

ipc_tests stdio

installer_util_unittests stdio

mini_installer_test stdio

sync_unit_tests 1 disabled stdio

unit_tests 15 disabled 1 flaky failed 1 stdio TestDownloadFilename

running app_unittests stdio

Changed by: tha...@chromium.org
Changed at: Sun 21 Feb 2010 17:53:45
Branch: src
Revision: 39588
Changed files:

• chrome/app/generated_resources.grd
• chrome/app/nibs/ClearBrowsingData.xib
• chrome/app/nibs/ContentBlockedCookies.xib
• chrome/app/nibs/ContentBlockedImages.xib
• chrome/app/nibs/ContentBlockedJavaScript.xib
• chrome/app/nibs/ContentBlockedPlugins.xib
• chrome/app/nibs/ContentBlockedPopups.xib
• chrome/app/nibs/ContentSettings.xib
• chrome/app/nibs/Preferences.xib
• chrome/browser/cocoa/browser_window_cocoa.h
• chrome/browser/cocoa/browser_window_cocoa.mm
• chrome/browser/cocoa/clear_browsing_data_controller.h
• chrome/browser/cocoa/clear_browsing_data_controller.mm
• chrome/browser/cocoa/content_blocked_bubble_controller.mm
• chrome/browser/cocoa/content_blocked_bubble_controller_unittest.mm
• chrome/browser/cocoa/content_settings_dialog_controller.h
• chrome/browser/cocoa/content_settings_dialog_controller.mm
• chrome/browser/cocoa/content_settings_dialog_controller_unittest.mm
• chrome/browser/cocoa/preferences_window_controller.h
• chrome/browser/cocoa/preferences_window_controller.mm
• chrome/chrome_browser.gypi
• chrome/chrome_dll.gypi
• chrome/chrome_tests.gypi

Comments:

Mac: Move prefs around in preparation for the content settings window.

Also introduce scaffolding for the actual content settings dialog.

xib changes:
+ Personal stuff
* Move "Clear browsing data" button to under the hood tab
* Move themes stuff up a bit to cover hole left by missing button

+ under the hood:
* Created "Content Settings..." button
* Got rid of cookie settings
* Moved stuff around

+ clear data:
* Added horizontal rule and flash player settings link, linked its action to
  new method.

+ content settings:
* Added mostly empty window that contains "This is not implemented yet" label and a button that shows cookies (since I removed that from the prefs, so that it's still available). This window will be fleshed out very soon (in my next CL).
* The window _is_ set up for l10n

+ bubble xibs:
* Enable "Manage" links now that they open a window

Four screenshots at http://imgur.com/axGiR&78O8g&wgk3p&6oOHj

BUG=34656,34894
TEST="Clear data" button has moved from "Personal Stuff" to "Under the hood" in prefs. There's a "Content Settings" button next to it that opens a mostly empty window. The "Clear data" dialog now has a link to flash's privacy settings (which hang if one has the AdThwart extension installed, heh).

Review URL: http://codereview.chromium.org/650124

Properties:

[Nico Weber]

Fixed by a clobber. Didn't grd dependency tracking work on windows at some point?

[Paweł Hajdan, Jr.]

No, it's still broken. Bradley Nelson is working on that step by step, many parts of it should be fixed now.

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev