git cl upload takes minutes on Windows

[Gabriel Charette]

Ever since the switch to gerrit : every time I git cl upload it takes > 1 minute.

My coworkers don't seem to be experiencing it as bad but I get this on all of my machines... how do I debug? The machine appears to be totally idle for most of it (related processes @ 0%).

I grabbed an ETW trace of it happening which I can share to individuals interested.

[Gabriel Charette]

I think it's network related, everything that interacts with the server seems to just wait endlessly for a reply.

presubmits alone take ~30s on a single file CL:

Running presubmit upload checks ...

  checking owners took a long time: 21425ms

[Colin Blundell]

On Wed, Jul 26, 2017 at 6:18 PM Gabriel Charette <g...@chromium.org> wrote:

I think it's network related, everything that interacts with the server seems to just wait endlessly for a reply.

presubmits alone take ~30s on a single file CL:

Running presubmit upload checks ...

  checking owners took a long time: 21425ms

Do presubmit checks interact with the server? I would think that the owners check doesn't at least.

 

On Wed, Jul 26, 2017 at 10:49 AM Gabriel Charette <g...@chromium.org> wrote:

Ever since the switch to gerrit : every time I git cl upload it takes > 1 minute.

My coworkers don't seem to be experiencing it as bad but I get this on all of my machines... how do I debug? The machine appears to be totally idle for most of it (related processes @ 0%).

I grabbed an ETW trace of it happening which I can share to individuals interested.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAJTZ7LKNMVkrXbP%2BTcgGvxViPvHtnv-bHBp4nbxPf16rQAoAWA%40mail.gmail.com.

[Gabriel Charette]

On Wed, Jul 26, 2017 at 1:31 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Jul 26, 2017 at 6:18 PM Gabriel Charette <g...@chromium.org> wrote:

I think it's network related, everything that interacts with the server seems to just wait endlessly for a reply.

presubmits alone take ~30s on a single file CL:

Running presubmit upload checks ...

  checking owners took a long time: 21425ms

Do presubmit checks interact with the server? I would think that the owners check doesn't at least.

Well I assumed it did because 21s to do an owners lookup for a single local file sounds even more ridiculous...

[Dirk Pranke]

On Wed, Jul 26, 2017 at 10:43 AM, Gabriel Charette <g...@chromium.org> wrote:

On Wed, Jul 26, 2017 at 1:31 PM Colin Blundell <blun...@chromium.org> wrote:

On Wed, Jul 26, 2017 at 6:18 PM Gabriel Charette <g...@chromium.org> wrote:

I think it's network related, everything that interacts with the server seems to just wait endlessly for a reply.

presubmits alone take ~30s on a single file CL:

Running presubmit upload checks ...

  checking owners took a long time: 21425ms

Do presubmit checks interact with the server? I would think that the owners check doesn't at least.

Well I assumed it did because 21s to do an owners lookup for a single local file sounds even more ridiculous...

Owners checking is a local operation. There's something badly wrong there. File a bug?

-- Dirk

[Bruce Dawson]

Maybe get an ETW trace (isolated, as before) of just "git cl owners", assuming that that also takes 21 s.

Looking at the trace you sent I see a ton (dozens?) of python processes that take ~40s to run, with these type of command lines:

    "D:\src\depot_tools\win_tools-2_7_6_bin\python\bin\python.exe" "-c" "from multiprocessing.forking import main; main()" "--multiprocessing-fork" "832"

Presubmits maybe? They are using roughly zero CPU time - I haven't yet looked to see what they are waiting on.

[Bruce Dawson]

I looked at one of the python multiprocessing processes to see why it was mostly idle (over ~40 s it ran for ~0.7 s). It contains four threads, all of which are idle most of the time:

The busiest thread (17,240) spend most of its time waiting on _multiprocessing.pyd!semlock_acquire. So, are we firing off dozens of multiprocessing scripts that then are gated by a single lock? That is the effect that we are getting in this trace anyway. I don't have any experience with Python multiprocessing.

This machine is 97% idle, which on a 48 thread machine means ~one process is running at a time. Fixing that will fix this problem.

[Wez]

The OWNERS check determines whether the CL already has reviewers associated with it that cover the modified files' OWNERS needs, IIRC.

I've just run a git cl presubmit in an already-uploaded branch (i.e. one with an associated CL) and I see two calls out to Gerrit, though a lot of the time seems to just be taken up running a variety of git commands.

I've also just run a git cl presubmit on a fresh branch and found that it doesn't do any Gerrit manipulations, as you'd expect, but the git command executions are many, and are pretty slow, FWIW.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAE5mQiNft9hhiGg8M-s_C%3D%3DqfZH4co-Djnj0288thRs0gs_6Fw%40mail.gmail.com.

[Dirk Pranke]

This is probably a dumb question, but are you sure you're getting the version of python in depot_tools, and not a different one?

-- Dirk

[Wez]

FWIW, the output of presubmit for a branch with a CL:

[D2017-07-26 11:35:29,601 60756 14900 subprocess2.py] C:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never update-index --refresh -q

[D2017-07-26 11:35:30,846 60756 14900 subprocess2.py] C:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never diff-index --name-status HEAD

[D2017-07-26 11:35:32,408 60756 14900 subprocess2.py] git symbolic-ref HEAD

[D2017-07-26 11:35:32,444 60756 14900 subprocess2.py] git config branch.dcheckSyzy.rietveldissue

[D2017-07-26 11:35:32,546 60756 14900 subprocess2.py] git config branch.dcheckSyzy.gerritissue

[D2017-07-26 11:35:32,647 60756 14900 subprocess2.py] git config branch.dcheckSyzy.merge

[D2017-07-26 11:35:32,733 60756 14900 subprocess2.py] git config branch.dcheckSyzy.remote

[D2017-07-26 11:35:32,816 60756 14900 subprocess2.py] git rev-parse --verify refs/remotes/origin/master

[D2017-07-26 11:35:32,920 60756 14900 subprocess2.py] C:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never config --get branch.dcheckSyzy.base

[D2017-07-26 11:35:32,976 60756 14900 subprocess2.py] C:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never config --get branch.dcheckSyzy.base-upstream

[D2017-07-26 11:35:33,028 60756 14900 subprocess2.py] C:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never merge-base refs/remotes/origin/master dcheckSyzy

[D2017-07-26 11:35:33,124 60756 14900 subprocess2.py] git rev-parse --verify 7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a

[D2017-07-26 11:35:33,213 60756 14900 subprocess2.py] git merge-base 7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a HEAD

[D2017-07-26 11:35:33,323 60756 14900 subprocess2.py] git rev-list ^7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a HEAD

[D2017-07-26 11:35:33,407 60756 14900 subprocess2.py] git config gitcl.remotebranch

[D2017-07-26 11:35:33,502 60756 14900 subprocess2.py] git config branch.dcheckSyzy.merge

[D2017-07-26 11:35:33,595 60756 14900 subprocess2.py] git config branch.dcheckSyzy.remote

[D2017-07-26 11:35:33,680 60756 14900 subprocess2.py] git rev-list ^7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a refs/remotes/origin/master

[D2017-07-26 11:35:33,776 60756 14900 subprocess2.py] git rev-parse --show-cdup

[D2017-07-26 11:35:33,832 60756 14900 subprocess2.py] git rev-parse HEAD

[D2017-07-26 11:35:33,969 60756 14900 subprocess2.py] git diff --name-status --no-renames -r 7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a... .;  cwd=.

[D2017-07-26 11:35:34,293 60756 14900 subprocess2.py] git config branch.dcheckSyzy.gerritpatchset

[D2017-07-26 11:35:34,388 60756 14900 subprocess2.py] git config branch.dcheckSyzy.gerritserver

[D2017-07-26 11:35:34,549 60756 14900 gerrit_util.py] GET https://chromium-review.googlesource.com/a/changes/559809/detail?o=CURRENT_REVISION&o=CURRENT_COMMIT

[D2017-07-26 11:35:34,563 60756 14900 gerrit_util.py] Authorization: HIDDEN

[D2017-07-26 11:35:35,969 60756 14900 gerrit_util.py] got response 200 for GET https://chromium-review.googlesource.com/a/changes/559809/detail?o=CURRENT_REVISION&o=CURRENT_COMMIT

[D2017-07-26 11:35:35,990 60756 14900 subprocess2.py] git config user.email

[D2017-07-26 11:35:36,081 60756 14900 presubmit_support.py] GitAffectedFile(base/feature_list.cc)

[D2017-07-26 11:35:36,089 60756 14900 presubmit_support.py] GitAffectedFile(base/logging.cc)

[D2017-07-26 11:35:36,099 60756 14900 presubmit_support.py] GitAffectedFile(base/logging.h)

[D2017-07-26 11:35:36,107 60756 14900 presubmit_support.py] GitAffectedFile(base/logging_unittest.cc)

Running presubmit commit checks ...

[D2017-07-26 11:35:36,141 60756 14900 presubmit_support.py] Presubmit files: C:\src\git-chrome\src\PRESUBMIT.py,C:\src\git-chrome\src\base\PRESUBMIT.py

Running C:\src\git-chrome\src\PRESUBMIT.py

[D2017-07-26 11:35:36,459 60756 14900 presubmit_support.py] Running CheckChangeOnCommit in C:\src\git-chrome\src\PRESUBMIT.py

[D2017-07-26 11:35:36,530 60756 14900 gerrit_util.py] GET https://chromium-review.googlesource.com/a/changes/559809/detail?o=ALL_REVISIONS&o=DETAILED_LABELS&o=ALL_COMMITS

[D2017-07-26 11:35:36,551 60756 14900 gerrit_util.py] Authorization: HIDDEN

[D2017-07-26 11:35:40,529 60756 14900 gerrit_util.py] got response 200 for GET https://chromium-review.googlesource.com/a/changes/559809/detail?o=ALL_REVISIONS&o=DETAILED_LABELS&o=ALL_COMMITS

[D2017-07-26 11:35:40,552 60756 14900 presubmit_canned_checks.py] owner: w...@chromium.org; approvals given by: asvi...@chromium.org, si...@chromium.org

  checking owners took a long time: 4104ms

[D2017-07-26 11:35:40,756 60756 14900 subprocess2.py] git diff -p --no-color --no-prefix --no-ext-diff 7c6a2f67fa5dafc2524e76ab30b9f8ac0ad7f41a...HEAD --no-renames;  cwd=C:\src\git-chrome\src

[D2017-07-26 11:35:41,201 60756 14900 presubmit_support.py] LocalPaths: ['base\\feature_list.cc', 'base\\logging.cc', 'base\\logging.h', 'base\\logging_unittest.cc']

[D2017-07-26 11:35:41,308 60756 14900 subprocess2.py] git cl format --dry-run C:\src\git-chrome\src

[D2017-07-26 11:35:45,855 60756 14900 presubmit_support.py] Running CheckChangeOnCommit done.

Running C:\src\git-chrome\src\base\PRESUBMIT.py

[D2017-07-26 11:35:46,345 60756 14900 presubmit_support.py] Running CheckChangeOnCommit in C:\src\git-chrome\src\base\PRESUBMIT.py

[D2017-07-26 11:35:46,367 60756 14900 presubmit_support.py] Running CheckChangeOnCommit done.

[Gabriel Charette]

On Wed, Jul 26, 2017 at 2:50 PM Dirk Pranke <dpr...@chromium.org> wrote:

This is probably a dumb question, but are you sure you're getting the version of python in depot_tools, and not a different one?

depot_tools is first in PATH and

$ where python

D:\src\depot_tools\python.bat

C:\python_27_amd64\files\python.exe

 

So unless something prefers the .exe over the .bat depot_tool's should be used (not sure why I have the other one in fact) 

-- Dirk

On Wed, Jul 26, 2017 at 11:47 AM, Bruce Dawson <bruce...@chromium.org> wrote:

I looked at one of the python multiprocessing processes to see why it was mostly idle (over ~40 s it ran for ~0.7 s). It contains four threads, all of which are idle most of the time:

The busiest thread (17,240) spend most of its time waiting on _multiprocessing.pyd!semlock_acquire. So, are we firing off dozens of multiprocessing scripts that then are gated by a single lock? That is the effect that we are getting in this trace anyway. I don't have any experience with Python multiprocessing.

This machine is 97% idle, which on a 48 thread machine means ~one process is running at a time. Fixing that will fix this problem.

[Scott Graham]

I think the idle python processes are not related to the problem. multiprocessing pre-makes a pool of workers of ~#cpus and has them wait for tasks dispatched by the main script process.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAE5mQiMsaqRLx-UwHYZmwHea5UcKiSqOaZFYFw_QJDO5Hg_Pcw%40mail.gmail.com.

[Gabriel Charette]

On Wed, Jul 26, 2017 at 2:57 PM Gabriel Charette <g...@chromium.org> wrote:

On Wed, Jul 26, 2017 at 2:50 PM Dirk Pranke <dpr...@chromium.org> wrote:

This is probably a dumb question, but are you sure you're getting the version of python in depot_tools, and not a different one?

depot_tools is first in PATH and

$ where python

D:\src\depot_tools\python.bat

C:\python_27_amd64\files\python.exe

 

So unless something prefers the .exe over the .bat depot_tool's should be used (not sure why I have the other one in fact) 

Seems depot_tools wins from my command prompt:

$ python

Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel)] on win32

Type "help", "copyright", "credits" or "license" for more information.

>>> import sys

>>> sys.executable

'D:\\src\\depot_tools\\win_tools-2_7_6_bin\\python\\bin\\python.exe'

[Wez]

Can you run git cl upload with "-vv" to see which command(s) are taking a long time - that'd help diagnose the likely Gerrit vs git question. :)

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAJTZ7LLeQqS9VOd9A47ZCAuD3OdG6-Fm6%3DsdFu482PbNtbu5TQ%40mail.gmail.com.

[Gabriel Charette]

Seems to be pausing ~25s to retry after getting some permission issues?

On Wed, Jul 26, 2017 at 3:04 PM Wez <w...@chromium.org> wrote:

Can you run git cl upload with "-vv" to see which command(s) are taking a long time - that'd help diagnose the likely Gerrit vs git question. :)

[D2017-07-26 15:09:13,792 17780 12040 subprocess2.py] git symbolic-ref HEAD

[D2017-07-26 15:09:13,838 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.git-cl-similarity

[D2017-07-26 15:09:13,894 17780 12040 subprocess2.py] git symbolic-ref HEAD

[D2017-07-26 15:09:13,930 17780 12040 subprocess2.py] git config --bool branch.2a3b_more_chrome/browser/printing_split.git-find-copies

[D2017-07-26 15:09:13,980 17780 12040 subprocess2.py] D:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never update-index --refresh -q

[D2017-07-26 15:09:15,020 17780 12040 subprocess2.py] D:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never diff-index --name-status HEAD

[D2017-07-26 15:09:16,469 17780 12040 subprocess2.py] git config rietveld.autoupdate

[D2017-07-26 15:09:16,499 17780 12040 git_cl.py] Failed running ['git', 'config', 'rietveld.autoupdate']

[D2017-07-26 15:09:16,500 17780 12040 subprocess2.py] git rev-parse --show-cdup

[D2017-07-26 15:09:16,532 17780 12040 subprocess2.py] git config rietveld.cc chromium...@chromium.org

[D2017-07-26 15:09:16,562 17780 12040 subprocess2.py] git config --unset-all rietveld.private

[D2017-07-26 15:09:16,595 17780 12040 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.private']

[D2017-07-26 15:09:16,596 17780 12040 subprocess2.py] git config rietveld.tree-status-url http://chromium-status.appspot.com/status

[D2017-07-26 15:09:16,630 17780 12040 subprocess2.py] git config rietveld.viewvc-url https://chromium.googlesource.com/chromium/src/+/

[D2017-07-26 15:09:16,664 17780 12040 subprocess2.py] git config --unset-all rietveld.bug-prefix

[D2017-07-26 15:09:16,694 17780 12040 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.bug-prefix']

[D2017-07-26 15:09:16,697 17780 12040 subprocess2.py] git config --unset-all rietveld.cpplint-regex

[D2017-07-26 15:09:16,726 17780 12040 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.cpplint-regex']

[D2017-07-26 15:09:16,730 17780 12040 subprocess2.py] git config rietveld.cpplint-ignore-regex webkit/api/.*

[D2017-07-26 15:09:16,760 17780 12040 subprocess2.py] git config rietveld.project chromium

[D2017-07-26 15:09:16,793 17780 12040 subprocess2.py] git config rietveld.run-post-upload-hook True

[D2017-07-26 15:09:16,825 17780 12040 subprocess2.py] git config gerrit.host True

[D2017-07-26 15:09:16,857 17780 12040 subprocess2.py] git config gerrit.host

[D2017-07-26 15:09:16,888 17780 12040 subprocess2.py] git symbolic-ref HEAD

[D2017-07-26 15:09:16,917 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.rietveldissue

[D2017-07-26 15:09:16,960 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.gerritissue

[D2017-07-26 15:09:17,000 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.merge

[D2017-07-26 15:09:17,040 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.remote

[D2017-07-26 15:09:17,082 17780 12040 subprocess2.py] git rev-parse --verify refs/heads/2a2_rm_messageloop_quit_simple

[D2017-07-26 15:09:17,164 17780 12040 subprocess2.py] D:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never config --get branch.2a3b_more_chrome/browser/printing_split.base

[D2017-07-26 15:09:17,213 17780 12040 subprocess2.py] D:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never config --get branch.2a3b_more_chrome/browser/printing_split.base-upstream

[D2017-07-26 15:09:17,253 17780 12040 subprocess2.py] D:\src\depot_tools\win_tools-2_7_6_bin\git\mingw64\libexec\git-core\git.exe -c color.ui=never merge-base refs/heads/2a2_rm_messageloop_quit_simple 2a3b_more_chrome/browser/printing_split

[D2017-07-26 15:09:17,325 17780 12040 subprocess2.py] git config --bool gerrit.skip-ensure-authenticated

[D2017-07-26 15:09:17,355 17780 12040 git_cl.py] Failed running ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']

[D2017-07-26 15:09:17,549 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.gerritserver

[D2017-07-26 15:09:17,591 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.merge

[D2017-07-26 15:09:17,631 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.remote

[D2017-07-26 15:09:17,674 17780 12040 subprocess2.py] git config branch.2a2_rm_messageloop_quit_simple.merge

[D2017-07-26 15:09:17,717 17780 12040 subprocess2.py] git config branch.2a2_rm_messageloop_quit_simple.remote

[D2017-07-26 15:09:17,760 17780 12040 subprocess2.py] git config branch.2a1_runloopquitwhenidle.merge

[D2017-07-26 15:09:17,805 17780 12040 subprocess2.py] git config branch.2a1_runloopquitwhenidle.remote

[D2017-07-26 15:09:17,848 17780 12040 subprocess2.py] git config remote.origin.url

[D2017-07-26 15:09:17,903 17780 12040 gerrit_util.py] GET https://chromium-review.googlesource.com/a/changes/587050/detail?o=DETAILED_ACCOUNTS&o=CURRENT_REVISION&o=CURRENT_COMMIT

[D2017-07-26 15:09:17,908 17780 12040 gerrit_util.py] Authorization: HIDDEN

(hung here for a while.....)

[D2017-07-26 15:09:42,762 17780 12040 gerrit_util.py] got response 200 for GET https://chromium-review.googlesource.com/a/changes/587050/detail?o=DETAILED_ACCOUNTS&o=CURRENT_REVISION&o=CURRENT_COMMIT

[D2017-07-26 15:09:42,778 17780 12040 subprocess2.py] git rev-parse --verify 7716ef06732e9da9499c0b1d7d792adab96b6038

[D2017-07-26 15:09:42,844 17780 12040 subprocess2.py] git merge-base 7716ef06732e9da9499c0b1d7d792adab96b6038 HEAD

[D2017-07-26 15:09:42,911 17780 12040 subprocess2.py] git rev-list ^7716ef06732e9da9499c0b1d7d792adab96b6038 HEAD

[D2017-07-26 15:09:42,980 17780 12040 subprocess2.py] git config gitcl.remotebranch

[D2017-07-26 15:09:43,025 17780 12040 subprocess2.py] git rev-list ^7716ef06732e9da9499c0b1d7d792adab96b6038 refs/remotes/origin/master

[D2017-07-26 15:09:43,095 17780 12040 subprocess2.py] git rev-parse --show-cdup

[D2017-07-26 15:09:43,124 17780 12040 subprocess2.py] git rev-parse HEAD

[D2017-07-26 15:09:43,200 17780 12040 subprocess2.py] git diff --name-status --no-renames -r 7716ef06732e9da9499c0b1d7d792adab96b6038... .;  cwd=.

[D2017-07-26 15:09:43,483 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.gerritpatchset

[D2017-07-26 15:09:43,523 17780 12040 subprocess2.py] git config user.email

[D2017-07-26 15:09:43,551 17780 12040 presubmit_support.py] GitAffectedFile(chrome/browser/printing/print_view_manager_base.cc)

Running presubmit upload checks ...

[D2017-07-26 15:09:43,680 17780 12040 presubmit_support.py] Presubmit files: D:\src\chrome2\src\PRESUBMIT.py,D:\src\chrome2\src\chrome\PRESUBMIT.py,D:\src\chrome2\src\chrome\browser\PRESUBMIT.py

Running D:\src\chrome2\src\PRESUBMIT.py

[D2017-07-26 15:09:43,835 17780 12040 presubmit_support.py] Running CheckChangeOnUpload in D:\src\chrome2\src\PRESUBMIT.py

[D2017-07-26 15:09:43,881 17780 12040 gerrit_util.py] GET https://chromium-review.googlesource.com/a/changes/587050/detail?o=ALL_REVISIONS&o=DETAILED_LABELS&o=ALL_COMMITS

[D2017-07-26 15:09:43,888 17780 12040 gerrit_util.py] Authorization: HIDDEN

(hung here for another while...)

[D2017-07-26 15:10:05,345 17780 12040 gerrit_util.py] got response 200 for GET https://chromium-review.googlesource.com/a/changes/587050/detail?o=ALL_REVISIONS&o=DETAILED_LABELS&o=ALL_COMMITS

[D2017-07-26 15:10:13,263 17780 12040 presubmit_canned_checks.py] owner: g...@chromium.org; approvals given by: scot...@chromium.org

  checking owners took a long time: 29425ms

[D2017-07-26 15:10:13,426 17780 12040 subprocess2.py] git diff -p --no-color --no-prefix --no-ext-diff 7716ef06732e9da9499c0b1d7d792adab96b6038...HEAD --no-renames;  cwd=D:\src\chrome2\src

[D2017-07-26 15:10:13,733 17780 12040 presubmit_support.py] LocalPaths: ['chrome\\browser\\printing\\print_view_manager_base.cc']

[D2017-07-26 15:10:13,750 17780 12040 subprocess2.py] git cl format --dry-run D:\src\chrome2\src

[D2017-07-26 15:10:16,592 17780 12040 presubmit_support.py] Running CheckChangeOnUpload done.

Running D:\src\chrome2\src\chrome\PRESUBMIT.py

[D2017-07-26 15:10:16,867 17780 12040 presubmit_support.py] Running CheckChangeOnUpload in D:\src\chrome2\src\chrome\PRESUBMIT.py

Done processing D:\src\chrome2\src\chrome\browser\printing\print_view_manager_base.cc

[D2017-07-26 15:10:17,338 17780 12040 presubmit_support.py] Running CheckChangeOnUpload done.

Running D:\src\chrome2\src\chrome\browser\PRESUBMIT.py

[D2017-07-26 15:10:17,813 17780 12040 presubmit_support.py] Running CheckChangeOnUpload in D:\src\chrome2\src\chrome\browser\PRESUBMIT.py

[D2017-07-26 15:10:17,834 17780 12040 presubmit_support.py] Running CheckChangeOnUpload done.

Presubmit checks took 34.8s to calculate.

Presubmit checks passed.

[D2017-07-26 15:10:18,476 17780 12040 subprocess2.py] git diff --no-ext-diff --stat -l100000 -C50 7716ef06732e9da9499c0b1d7d792adab96b6038 HEAD

 chrome/browser/printing/print_view_manager_base.cc | 9 +++++----

 1 file changed, 5 insertions(+), 4 deletions(-)

[D2017-07-26 15:10:18,753 17780 12040 subprocess2.py] git config --bool gerrit.override-squash-uploads

[D2017-07-26 15:10:18,802 17780 12040 git_cl.py] Failed running ['git', 'config', '--bool', 'gerrit.override-squash-uploads']

[D2017-07-26 15:10:18,805 17780 12040 subprocess2.py] git config --bool gerrit.squash-uploads

[D2017-07-26 15:10:18,842 17780 12040 git_cl.py] Failed running ['git', 'config', '--bool', 'gerrit.squash-uploads']

[D2017-07-26 15:10:18,845 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.merge

[D2017-07-26 15:10:18,895 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.remote

[D2017-07-26 15:10:18,944 17780 12040 subprocess2.py] git config branch.2a2_rm_messageloop_quit_simple.gerritsquashhash

[D2017-07-26 15:10:18,993 17780 12040 subprocess2.py] git rev-parse refs/heads/2a2_rm_messageloop_quit_simple:

[D2017-07-26 15:10:19,085 17780 12040 subprocess2.py] git rev-parse d5805905ee04404d11a492e877977a0cf49a2b8a:

[D2017-07-26 15:10:19,180 17780 12040 subprocess2.py] git rev-parse HEAD:

[D2017-07-26 15:10:19,253 17780 12040 subprocess2.py] git commit-tree 39c02f1d170ef94edce643d074a24306ce764391 -p d5805905ee04404d11a492e877977a0cf49a2b8a -m Manually migrate away from more deprecated MessageLoop::Quit*() methods in /chrome/browser/printing.

This follows an automated pass for simpler use cases @

https://chromium-review.googlesource.com/c/585732/.

Minimal cleanup was made when trivial.

(some calls were even removed as they merely added a redundant QuitWhenIdle()

to a RunLoop().RunUntilIdle() call)

When too complex I defaulted to the lesser bad alternative of

RunLoop::QuitCurrent*Deprecated() methods.

I will not engage in further cleanups as part of this massive

change -- owners are welcome to follow suit with better usage

of RunLoop if unsatisfied with this).

This CL was uploaded by git cl split.

R=scot...@chromium.org

Bug: 748715

Change-Id: I89ee25215331f116bfdfe047c73e49dda00c1518

[D2017-07-26 15:10:19,364 17780 12040 subprocess2.py] git rev-list d5805905ee04404d11a492e877977a0cf49a2b8a..af4e8904595fef38a1bd29edf4e698c47c94797c

[D2017-07-26 15:10:19,460 17780 12040 subprocess2.py] git config remote.origin.url

[D2017-07-26 15:10:19,496 17780 12040 subprocess2.py] git push https://chromium.googlesource.com/chromium/src.git af4e8904595fef38a1bd29edf4e698c47c94797c:refs/for/refs/heads/master%notify=NONE,m=noop

remote: Processing changes: updated: 1 (-)

(then here...)

remote: (W) af4e890: commit subject >50 characters; use shorter first paragraph

remote: (W) No changes between prior commit 9528349 and new commit af4e890

remote:

remote: Updated Changes:

remote:   https://chromium-review.googlesource.com/587050 Manually migrate away from more deprecated MessageLoop::Quit*() methods in ...

remote:

To https://chromium.googlesource.com/chromium/src.git

 * [new branch]      af4e8904595fef38a1bd29edf4e698c47c94797c -> refs/for/refs/heads/master%notify=NONE,m=noop

[D2017-07-26 15:11:17,105 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.gerritissue 587050

[D2017-07-26 15:11:17,141 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.gerritserver https://chromium-review.googlesource.com

[D2017-07-26 15:11:17,177 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.gerritsquashhash af4e8904595fef38a1bd29edf4e698c47c94797c

[D2017-07-26 15:11:17,213 17780 12040 subprocess2.py] git config rietveld.cc

[D2017-07-26 15:11:17,256 17780 12040 gerrit_util.py] POST https://chromium-review.googlesource.com/a/changes/587050/revisions/current/review

[D2017-07-26 15:11:17,259 17780 12040 gerrit_util.py] Content-Type: application/json

[D2017-07-26 15:11:17,262 17780 12040 gerrit_util.py] Authorization: HIDDEN

[D2017-07-26 15:11:17,266 17780 12040 gerrit_util.py] {"reviewers": [{"reviewer": "chromium...@chromium.org", "state": "CC", "notify": "NONE"}, {"reviewer": "scot...@chromium.org", "state": "REVIEWER", "notify": "NONE"}], "notify": "NONE"}

[D2017-07-26 15:11:19,668 17780 12040 gerrit_util.py] got response 200 for POST https://chromium-review.googlesource.com/a/changes/587050/revisions/current/review

[D2017-07-26 15:11:19,674 17780 12040 subprocess2.py] git rev-parse HEAD

[D2017-07-26 15:11:19,739 17780 12040 subprocess2.py] git symbolic-ref HEAD

[D2017-07-26 15:11:19,766 17780 12040 subprocess2.py] git config branch.2a3b_more_chrome/browser/printing_split.last-upload-hash 2158a95458af6752eee550153ff9ae1ffdd85dc6

[D2017-07-26 15:11:19,801 17780 12040 subprocess2.py] git config rietveld.run-post-upload-hook

[D2017-07-26 15:11:19,842 17780 12040 presubmit_support.py] Presubmit files: D:\src\chrome2\src\PRESUBMIT.py,D:\src\chrome2\src\chrome\PRESUBMIT.py,D:\src\chrome2\src\chrome\browser\PRESUBMIT.py

Running D:\src\chrome2\src\chrome\browser\PRESUBMIT.py

Running D:\src\chrome2\src\chrome\PRESUBMIT.py

Running D:\src\chrome2\src\PRESUBMIT.py

[Dirk Pranke]

Let's take this to a bug, we don't need to swamp the list with a bunch of debug logs :).

-- Dirk

[Gabriel Charette]

On Wed, Jul 26, 2017 at 3:13 PM Dirk Pranke <dpr...@chromium.org> wrote:

Let's take this to a bug, we don't need to swamp the list with a bunch of debug logs :).

https://crbug.com/749229