"gclient sync" issue

[Oleksii Kadurin]

Hi! I'm trying to install the chromium project first time on a new Windows OS. (I have successful experience, but on another instance.)
I successfully installed dep_tools, then ran "fetch --nohooks --no-history chromium" and at some point I stopped it
and ran then "gclient sync -j1 -v" to see some logs.

It downloaded about 15GB and at the end it outputted:

[0:52:09]  = [up to date]      nougat-release          -> origin/nougat-release
[0:52:09]  = [up to date]      upstream-vulkan-cts-1.0-dev -> origin/upstream-vulkan-cts-1.0-dev
[0:52:12] Checked out f4f3d8079e7a37d7675ab93583e6438d0bca0e58 to a detached HEAD. Before making any commits
in this repo, you should use 'git checkout <branch>' to switch to
an existing branch or use 'git checkout origin -b <branch>' to
create a new branch for your work.
[0:52:12] Finished.
----------------------------------------


________ running 'C:\depot_tools\python276_bin\python.exe src/build/landmines.py' in 'C:\chromium'






Please follow the instructions at https://www.chromium.org/developers/how-tos/build-instructions-windows




Traceback (most recent call last):
  File "src/build/landmines.py", line 138, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 125, in main
    gyp_environment.SetEnvironment()
  File "C:\chromium\src\build\gyp_environment.py", line 30, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "C:\chromium\src\build\vs_toolchain.py", line 46, in SetEnvironmentAndGetRuntimeDllDirs
    Update()
  File "C:\chromium\src\build\vs_toolchain.py", line 360, in Update
    subprocess.check_call(get_toolchain_args)
  File "C:\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\depot_tools\\python276_bin\\python.exe', 'C:\\depot_tools\\win_toolchain\\get_toolchain_if_necessary.py', '--output-json', 'C:\\chromium\\src\\build\\win_toolchain.json', 'd5dc33b15d1b2c086f2f6632e2fd15882f80dbd3']' returned non-zeroexit status 1
Error: Command 'C:\\depot_tools\\python276_bin\\python.exe src/build/landmines.py' returned non-zero exit status 1 in C:\chromium

Then I ran the command again. And output is almost the same:

C:\chromium>gclient sync
Syncing projects: 100% (77/77), done.


________ running 'C:\depot_tools\python276_bin\python.exe src/build/landmines.py' in 'C:\chromium'






Please follow the instructions at https://www.chromium.org/developers/how-tos/build-instructions-windows




Traceback (most recent call last):
  File "src/build/landmines.py", line 138, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 125, in main
    gyp_environment.SetEnvironment()
  File "C:\chromium\src\build\gyp_environment.py", line 30, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "C:\chromium\src\build\vs_toolchain.py", line 46, in SetEnvironmentAndGetRuntimeDllDirs
    Update()
  File "C:\chromium\src\build\vs_toolchain.py", line 360, in Update
    subprocess.check_call(get_toolchain_args)
  File "C:\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\depot_tools\\python276_bin\\python.exe', 'C:\\depot_tools\\win_toolchain\\get_toolchain_if_necessary.py', '--output-json', 'C:\\chromium\\src\\build\\win_toolchain.json', 'd5dc33b15d1b2c086f2f6632e2fd15882f80dbd3']' returned non-zeroexit status 1
Error: Command 'C:\\depot_tools\\python276_bin\\python.exe src/build/landmines.py' returned non-zero exit status 1 in C:\chromium


C:\chromium>

The versions of node and python are as follows:

c:\chromium>node -v
v6.9.2


c:\chromium>python --version
Python 2.7.6

Any ideas why it happens? 
Thanks for reply!

[Scott Graham]

It's a bit buried in the instructions, but

"""Also, add a DEPOT_TOOLS_WIN_TOOLCHAIN system variable in the same way, and set it to 0. This tells depot_tools to use your locally installed version of Visual Studio (by default, depot_tools will try to use a google-internal version)."""

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Dirk Pranke]

We should see if we can handle that error case more cleanly, since I'd guess it is fairly common.

Also, any suggestions on how to make those instructions be less buried are welcome!

-- Dirk

[Oleksii Kadurin]

Thanks! Now it outputs:

c:\chromium>gclient sync

Syncing projects: 100% (77/77), done.

________ running 'C:\depot_tools\python276_bin\python.exe src/build/landmines.py' in 'c:\chromium'

Traceback (most recent call last):
  File "src/build/landmines.py", line 138, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 125, in main
    gyp_environment.SetEnvironment()

  File "c:\chromium\src\build\gyp_environment.py", line 30, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "c:\chromium\src\build\vs_toolchain.py", line 78, in SetEnvironmentAndGetRuntimeDllDirs
    os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath()
  File "c:\chromium\src\build\vs_toolchain.py", line 154, in DetectVisualStudioPath
    ' not found.') % (version_as_year))
Exception: Visual Studio Version 2015 (from GYP_MSVS_VERSION) not found.
Error: Command 'C:\\depot_tools\\python276_bin\\python.exe src/build/landmines.py' returned non-zero exit status 1 in c:\chromium

This is a fresh OS, so I forgot that there's no Visual Studio in there. So I visited the instruction page (the one which is specified in the error output: https://www.chromium.org/developers/how-tos/build-instructions-windows). 

It seems that it's possible to install  Windows SDK 8.1 to fix that issue. So I installed it, cause it's much faster. 

But no luck. The error is the same :(

Is there somewhere another version of instruction? It seems there should be some environment properties set in case of non-VisualStudio installation.

[Christian Biesinger]

You need to install Visual Studio...

https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md#Visual-Studio

Christian

[Oleksii Kadurin]

I see. Thank you!

[Oleksii Kadurin]

HI! Changing the instruction URL would really help

[Dirk Pranke]

Which URL are you referring to? 

http://www.chromium.org/developers/how-tos/build-instructions-windows

links to the new page:

https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md

Are you suggesting that it should just redirect instead? Or is there some other link on some other

page that you think should point to the googlesource.com link instead?

-- Dirk

[Oleksii Kadurin]

I'm sorry. When I first time visited the page in here http://www.chromium.org/developers/how-tos/build-instructions-windows I didn't noticed the message "See them here".

Instead for some reason I clicked on the "Work around for MSVS 2013" at the bottom.