Incrementally build the changes

71 views
Skip to first unread message

goe...@umich.edu

unread,
Apr 1, 2019, 1:08:55 PM4/1/19
to Chromium-dev
I realize this is a common question, but I couldn't find the answer I was looking for from the previous posts. 

What is the most efficient way to test out your changes, in the sense, spending least amount of time having to recompile chrome. 

For example if I change a file :./content/common/dom_storage/dom_storage_types.h , which targets should I be recompiling, for the shortest compilation time. 

Obviously, I can compile "chrome" target, but that would take the longest time I assume, despite being an incremental build. 
I tried building the  "content" target ( since my changed file is rooted at the "content" directory) however I saw my change not being reflected?


Torne (Richard Coles)

unread,
Apr 1, 2019, 1:16:10 PM4/1/19
to goe...@umich.edu, Chromium-dev
You need to recompile the target you are running, so if you are running chrome, you need to compile chrome. It already only builds the things that it has to build because of your change automatically - whatever it builds is what is necessary.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/c5a21d6d-00cd-4769-b662-bd421c36187d%40chromium.org.

Ayush Goel

unread,
Apr 1, 2019, 2:23:22 PM4/1/19
to Torne (Richard Coles), Chromium-dev
Thanks for your reply. 

This is not exactly related with the original question, however I modified the value of “kPerStorageAreaQuota inside content/common/dom_storage/dom_storage_types.h, changing it from 10MB to 20MB. I was hoping this would change the size quota of local storage provided by Chrome. However recompiling with this change, doesn’t change the local storage quota. 
Assuming I recompiled correctly, I am assuming this is not the file which specifies the size limit of localStorage provided by Chrome. Could you point to the correct file where I should be making the change. 

-Ayush

Torne (Richard Coles)

unread,
Apr 1, 2019, 2:44:15 PM4/1/19
to Ayush Goel, Chromium-dev
That seems like the right place to me, so if that's not working I don't know what to suggest instead, sorry.
Reply all
Reply to author
Forward
0 new messages