gn gen doesn't work for Android with enable_resource_whitelist_generation = true

[kuzne...@yandex-team.ru]

ERROR at //tools/grit/grit_rule.gni:94:1: Assertion failed.
assert(!enable_resource_whitelist_generation || is_android,
^-----
resource whitelist generation only works on android
See //net/BUILD.gn:16:1: whence it was imported.
import("//tools/grit/grit_rule.gni")
^----------------------------------
See //third_party/blink/renderer/platform/BUILD.gn:191:5: which caused the file to be included.
    "//net",
    ^------

gn refs says:

gn refs out/Default "//net(//build/toolchain/linux:clang_x64)" --tree
//components/subresource_filter/core/common:common(//build/toolchain/linux:clang_x64)
  //components/subresource_filter/core/browser:browser(//build/toolchain/linux:clang_x64)
    //components/subresource_filter/tools:tools_lib(//build/toolchain/linux:clang_x64)
      //components/subresource_filter/tools:subresource_indexing_tool(//build/toolchain/linux:clang_x64)
        //components/subresource_filter/tools:index_ruleset
          //tools/perf:perf
            //chrome/test:telemetry_perf_tests
              //chrome/test:performance_test_suite
                //chrome/test:performance_webview_test_suite
              //chrome/test:telemetry_perf_webview_tests
            //chrome/test:telemetry_perf_unittests
              //:gn_all
            //tools/perf/contrib/vr_benchmarks:vr_perf_tests
              //:gn_all
          //tools/perf:perf_without_chrome
            //chrome/test:telemetry_perf_tests_without_chrome
  //components/subresource_filter/tools:tools_lib(//build/toolchain/linux:clang_x64)...
//net:net(//build/toolchain/linux:clang_x64)
  //components/subresource_filter/core/common:common(//build/toolchain/linux:clang_x64)...

Is it ok to build //net for host tool?

[Colin Blundell]

What's your GN configuration?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/d1265052-2c64-4655-bc50-c3ba877f9855%40chromium.org.

[kuzne...@yandex-team.ru]

is_component_build = true
is_debug = true
target_os = "android"
target_cpu = "arm"
is_clang = true
symbol_level = 1
remove_webcore_debug_symbols = false
use_jumbo_build = true
enable_resource_whitelist_generation = true

[Nico Weber]

As you say, that's because setting enable_resource_whitelist_generation to true in args.gn enables it globally, including for host builds.

enable_resource_whitelist_generation is set to true for target builds if you set is_official_build = true. Is there any reason why you can't set that?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/1620f59d-7f15-4d8e-9343-8ad885348976%40chromium.org.

[Torne (Richard Coles)]

We should probably remove the declare_args for enable_resource_whitelist_generation entirely then, if setting it doesn't actually work?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGbLiGOm1suuZGGh_NV_dNCPomo_t0J%2BQBi1osA_8m-v8x4DA%40mail.gmail.com.

[Nico Weber]

Sounds right to me (but I didn't add it).

[kuzne...@yandex-team.ru]

Thanks, I've missed the fact, that enable_resource_whitelist_generation is already set for official builds for android.