To browse chromium code by Cr-Commit-Position

782 views
Skip to first unread message

Deng, Pan

unread,
Oct 8, 2014, 6:25:27 AM10/8/14
to chromi...@chromium.org

Hi,

 

Since chromium migrated to git months ago, viewvc[1] seems not useful anymore.

Is there a similar web tool to browse code? Especially to browse commits by Cr-Commit-Position number(may plus branch info), that will be quite useful.

 

Thanks

Pan

 

[1] https://src.chromium.org/viewvc/chrome/

 

Mattias Nissler

unread,
Oct 8, 2014, 10:25:32 AM10/8/14
to pan....@intel.com, chromi...@chromium.org

-----------------------------------------------
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Steuernummer: 48/725/00206 
Umsatzsteueridentifikationsnummer: DE813741370

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

Haixia Shi

unread,
Oct 8, 2014, 1:35:04 PM10/8/14
to mnis...@chromium.org, pan....@intel.com, chromi...@chromium.org
You could add a "pretty" argument to see the full commit messages (including the Cr-Commit-Position for each commit), for example

Deng, Pan

unread,
Oct 10, 2014, 8:43:22 AM10/10/14
to Haixia Shi, mnis...@chromium.org, chromi...@chromium.org

That is great, thanks

Furthermore, is it possible to use a cr-commit-position argument?

Now we can use the git hash to access a commit, e.g.

https://chromium.googlesource.com/chromium/src/+/8ea251ca5220a7875f9d50a583575b07522d478c

if we can use cr-comit-position, it would be better, something like

https://chromium.googlesource.com/chromium/src?cr-commit-position=...

 

Pan

PhistucK

unread,
Oct 10, 2014, 8:51:36 AM10/10/14
to Deng, Pan, Haixia Shi, mnis...@chromium.org, chromi...@chromium.org
Yeah, a Cr-Commit-Position to git hash conversion tool in https://omahaproxy.appspot.com/ (it has version to commit position, for example) would be nice. :)


PhistucK

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

Greg Thompson

unread,
Oct 10, 2014, 10:40:39 PM10/10/14
to PhistucK Productions, Deng, Pan, Haixia Shi, mnis...@chromium.org, chromi...@chromium.org
Does http://crrev.com/cr-commit-position meet your needs? It doesn't always work, but it often does.

PhistucK

unread,
Oct 11, 2014, 4:17:42 AM10/11/14
to Greg Thompson, Deng, Pan, Haixia Shi, mnis...@chromium.org, chromi...@chromium.org
Right, forgot about that!...


PhistucK

Aaron Gable

unread,
Oct 11, 2014, 5:10:21 AM10/11/14
to PhistucK Productions, Greg Thompson, Mike Stipicevic, Deng, Pan, Haixia Shi, mnis...@chromium.org, chromi...@chromium.org

Can you clarify under what circumstances crrev.com/cr-commit-position doesn't work? It should work all the time for src.git.

Greg Thompson

unread,
Oct 11, 2014, 10:27:49 AM10/11/14
to Aaron Gable, chromium-dev, Haixia Shi, PhistucK Productions, Mike Stipicevic, mnis...@chromium.org, Deng, Pan

I've repeatedly had it give me an unrelated cl. If memory serves, sometimes in a different repo. I figured it was due to a collision with a true commit prefix. I'll reply the next time it happens.

Reply all
Reply to author
Forward
0 new messages