transitionType "auto_toplevel" in extensions webNavigation API?

[Marcin Simonides]

Hello,

the documentation for the chrome.webNavigation.onCommitted event[1] in the webNavigation API mentions that the details.transitionType can have one of the following values:

"link", "typed", "auto_bookmark", "auto_subframe", "manual_subframe", "generated","start_page", "form_submit", "reload", "keyword", or "keyword_generated"

There is "auto_bookmark", "auto_subframe" but no "auto_toplevel". However, in the chromium code there is a PAGE_TRANSITION_AUTO_TOPLEVEL value. Is it just an omission in the extensions API or is it guaranteed that extensions will never receive any chrome.webNavigation.onCommitted events for "auto_toplevel" transitions?

[1] http://developer.chrome.com/extensions/webNavigation.html#event-onCommitted

[Jochen Eisinger]

no, the other types were added after the api was written, and the api documentation was never updated :-/

Can you file a bug for this?

best

-jochen

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Marcin Simonides]

Ok, filed https://code.google.com/p/chromium/issues/detail?id=334669

If it's just a matter of adding the "auto_toplevel" value to chrome/common/extensions/api/web_navigation.json than I can make the fix.

[Jochen Eisinger]

On Wed, Jan 15, 2014 at 4:42 PM, Marcin Simonides <msimo...@opera.com> wrote:

Ok, filed https://code.google.com/p/chromium/issues/detail?id=334669

If it's just a matter of adding the "auto_toplevel" value to chrome/common/extensions/api/web_navigation.json than I can make the fix.

That depends a bit on what those values mean and whether we want to expose them on the API or rather map to one of the pre-existing types.

We should discuss that on the bug

best

-jochen