interactive_ui_tests flakiness

13 views
Skip to first unread message

Fred Akalin

unread,
May 15, 2013, 3:12:12 PM5/15/13
to chromium-dev
Hey guys,

I've noticed that interactive_ui_tests is probably the flakiest test executable recently. I almost always have one or two trybots fail on it, and it closes the tree semi-regularly.

I don't think it was always this way. Is someone looking into why this got so flaky recently?

-- Fred

Ryan Hamilton

unread,
May 15, 2013, 6:48:30 PM5/15/13
to Fred Akalin, chromium-dev
+1  


--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
 
 
 

Fady Samuel

unread,
May 15, 2013, 6:52:56 PM5/15/13
to r...@chromium.org, Fred Akalin, chromium-dev
+1, we're seeing a lot of WebViewInteractiveTest flakiness, but we can't repro locally and haven't been able to explain the flakiness. What's going on?

Scott Violet

unread,
May 15, 2013, 8:09:13 PM5/15/13
to Fady Samuel, r...@chromium.org, Fred Akalin, chromium-dev
Is it at all related to 177163?

Yoyo Zhou

unread,
May 15, 2013, 8:41:59 PM5/15/13
to Scott Violet, Fady Samuel, Ryan Hamilton, Fred Akalin, chromium-dev
177163 is believed only to affect Win debug bots, no? I've been
noticing interactive_ui_tests flaking on other platforms.

James Cook

unread,
May 16, 2013, 9:31:43 AM5/16/13
to Yoyo Zhou, Scott Violet, Fady Samuel, Ryan Hamilton, Fred Akalin, chromium-dev
Unscientific, but win_rel seems to be flaking for my try jobs on WebViewInteractiveTest.NewWindow

mac_rel likes to choke on instant extended tests, like:
InstantExtendedTest.ExtendedModeIsOn
InstantExtendedTest.MiddleClickOnSuggestionOpensInNewTab: 
InstantExtendedTest.OverlayDoesntSupportInstant: 
etc.

Charlie Reis

unread,
May 16, 2013, 12:28:45 PM5/16/13
to James Cook, Yoyo Zhou, Scott Violet, Fady Samuel, Ryan Hamilton, Fred Akalin, chromium-dev
+1 to seeing lots of interactive_ui_test flakiness.

As I was sheriffing last week, it was particularly bad in the ExtensionCrashRecoveryTests across various Windows and Linux bots.  I found that https://code.google.com/p/chromium/issues/detail?id=174705 was filed for it, but no one seems to be working on it.

We saw lots of other interactive_ui_tests fail as well, though, so the problem does feel widespread (for both the tree and trybots).

Charlie

Paweł Hajdan, Jr.

unread,
May 16, 2013, 6:08:36 PM5/16/13
to cr...@chromium.org, James Cook, Yoyo Zhou, Scott Violet, Fady Samuel, Ryan Hamilton, Fred Akalin, chromium-dev
interactive_ui_tests do a lot of things that are flakiness-prone, like focus, OS-level mouse and keyboard events, and so on.

Please keep filing bugs and disabling flakes you see.

http://chromium-build-logs.appspot.com/ can be useful to see the history of past test failures.

Paweł

Fady Samuel

unread,
May 16, 2013, 11:27:46 PM5/16/13
to Paweł Hajdan, Jr., Charlie Reis, James Cook, Yoyo Zhou, Scott Violet, Ryan Hamilton, Fred Akalin, chromium-dev
Something very odd is happening with WebViewInteractiveTest.NewWindow. It's failing here on a NOTREACHED() here:


This indicates that a shared memory buffer was not mapped successfully. Is Windows running out of memory? Should I simply remove the NOTREACHED() here?

Fady

Paweł Hajdan, Jr.

unread,
May 17, 2013, 1:33:38 PM5/17/13
to Fady Samuel, Charlie Reis, James Cook, Yoyo Zhou, Scott Violet, Ryan Hamilton, Fred Akalin, chromium-dev
On Thu, May 16, 2013 at 8:27 PM, Fady Samuel <fsa...@google.com> wrote:
Something very odd is happening with WebViewInteractiveTest.NewWindow. It's failing here on a NOTREACHED() here:


This indicates that a shared memory buffer was not mapped successfully. Is Windows running out of memory? Should I simply remove the NOTREACHED() here?

Generally I wouldn't be so eager to remove a NOTREACHED() - after all, it was put there for a reason, to alert us about issues the developer putting it there thought should not happen.

Fady Samuel

unread,
May 17, 2013, 1:36:57 PM5/17/13
to Paweł Hajdan, Jr., Charlie Reis, James Cook, Yoyo Zhou, Scott Violet, Ryan Hamilton, Fred Akalin, chromium-dev
I know. I put it there. :-)

I have no idea why mapping a shared memory buffer is failing. It shouldn't fail. BrowserPlugin expects this to work...

Did anything change about the Windows sandbox recently?

Fady

Paweł Hajdan, Jr.

unread,
May 20, 2013, 1:26:42 PM5/20/13
to Fady Samuel, Charlie Reis, James Cook, Yoyo Zhou, Scott Violet, Ryan Hamilton, Fred Akalin, chromium-dev
On Fri, May 17, 2013 at 10:36 AM, Fady Samuel <fsa...@google.com> wrote:
I have no idea why mapping a shared memory buffer is failing. It shouldn't fail. BrowserPlugin expects this to work...

I don't know enough about BrowserPlugin to make a judgment here.

Note that SharedMemory::Map can fail, so NOTREACHING() on that seems wrong (you cannot be sure it will never fail - for example the system may legitimately run out of resources).

I can recommend adding more logging to help debug this - chromium-build-logs.appspot.com will collect the failing logs so you'll be able to easily get to them later.

Paweł
Reply all
Reply to author
Forward
0 new messages