> Chrome already allows TODO(bug number). In fact it's preferred:Then my suggest is to(1) change the presubmit check so it requires an bug number and fails on just an owner(2) change the message so it says "TODO missing bug number" instead of what it says now which is "TODO missing owner"Can we do this or will their be pushback?On Friday, September 5, 2025 at 1:40:49 PM UTC-7 Joe Mason wrote:Chrome already allows TODO(bug number). In fact it's preferred: see https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-dos-and-donts.md#comment-style.On Fri, Sep 5, 2025 at 4:37 PM Gregg Tavares <gm...@chromium.org> wrote:Chromium currently has the requirement that a TODO comment left in the code needs to be in form TODO(owner): msg or TODO: owner - msgWDTY about changing the requirement to TODO(issue): msg and TODO: issue - msg ?// TODO(12345678): Fix the thing// TODO(crbug.com/12345678): Fix the thing// TODO(https://crbug.com/12345678): Fix the thing// TODO:12345678 - Fix the thing// TODO:crbug.com/12345678 - Fix the thing// TODO:https://crbug.com/12345678 - Fix the thingWould all be validOwners leave the team so having TODO(person-no-longer-available) is not that useful. Issues stick around and allow discussion and context.The actual check would just just switch from checking TODO(anything): and TODO:anything - to TODO(anything\d+): and TODO:anything\d+ -Thoughts?--
--
Chromium Discussion mailing list: chromium...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-discuss