Issues with git cl upload after rebasing

[Alex Newcomer]

Hello, I recently rebased and I can no longer git cl upload. Has anyone seen this error before?

I did a git cl creds-check and everything seems normal.

[finch_config-0 1e2f3da07662b] cros:Land finch config for VC DLC UI
 Date: Mon Jun 24 23:09:58 2024 +0000
 6 files changed, 62 insertions(+), 15 deletions(-)
Found change with 1 commit...
Traceback (most recent call last):
  File "/usr/local/google/home/newcomer/depot_tools/metrics.py", line 290, in print_notice_and_exit
    yield
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 6924, in <module>
    sys.exit(main(sys.argv[1:]))
             ^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 6905, in main
    return dispatcher.execute(OptionParser(), argv)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/newcomer/depot_tools/subcommand.py", line 254, in execute
    return command(parser, args[1:])
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 5181, in CMDupload
    UploadAllSquashed(options, orig_args)
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 5281, in UploadAllSquashed
    new_upload = cl.PrepareSquashedCommit(options,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 1960, in PrepareSquashedCommit
    reviewers, ccs, change_desc = self._PrepareChange(
                                  ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 2017, in _PrepareChange
    self.EnsureCanUploadPatchset(options.force)
  File "/usr/local/google/home/newcomer/depot_tools/git_cl.py", line 2359, in EnsureCanUploadPatchset
    emails = gerrit_util.GetAccountEmails(self.GetGerritHost(), 'self')
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/newcomer/depot_tools/gerrit_util.py", line 1684, in GetAccountEmails
    authenticator=authenticator)
                  ^^^^^^^^^^^^^
NameError: name 'authenticator' is not defined

[Dirk Pranke]

Looks like a recent change introduced a typo. Hopefully it will be fixed shortly, or you can check out depot_tools at 3a5d348a in the meantime, hopefully that will unblock you.

-- Dirk

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/63a06512-2c5c-4ffb-a983-f88cd8d05757n%40chromium.org.

[Alex Newcomer]

Thanks! I rebased this morning and all is normal.