ERROR at //skia/BUILD.gn:554:16: Undefined identifier

124 views
Skip to first unread message

Robin Gupta

unread,
Aug 2, 2023, 1:50:50 PM8/2/23
to Chromium-dev
Hi team,

I am trying to port two Chromedriver fixes (Commits 841d419a258f9e1f5e978cdad4a0a9574504456b and a520d077d669896ce3595bb80c1a973b5596a216) from  117.0.5921.1  to  114.0.5735.90 .
My local setup for Chromedriver was working fine before I made the changes to the below files and I was able to build chromedriver successfully. 
The files updated as per the commits are:
  1. 841d419a258f9e1f5e978cdad4a0a9574504456b 
    1. chrome/test/chromedriver/chrome/devtools_client_impl.cc
    2. chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
    3. chrome/test/chromedriver/element_util.cc
    4. chrome/test/chromedriver/test/run_py_tests.py
  2. a520d077d669896ce3595bb80c1a973b5596a216
    1. chrome/test/chromedriver/session_commands.cc

After the above files are updated in the code checked out for  114.0.5735.90 as per the above changes , I am trying to build chromedriver using the command  "autoninja -C out\Default chromedriver" locally, I am getting the error as below:

"C:\src\depot_tools\bootstrap-2@3_8_10_chromium_26_bin\python3\bin\python3.exe" C:\src\depot_tools\ninja.py -C outDefault chromedriver -j 14
ERROR at //skia/BUILD.gn:554:16: Undefined identifier
    sources += skia_gpu_private
               ^---------------
See //BUILD.gn:103:7: which caused the file to be included.
      "//skia:skia_unittests",
      ^----------------------
ninja: error: rebuilding 'build.ninja': subcommand failed
ninja: Entering directory `outDefault'
[0/1] Regenerating ninja files
FAILED: build.ninja.stamp
../buildtools/win/gn.exe --root=./.. -q --regeneration gen .

Attached screenshot for reference:

chromedriverbuildfail.png

Steps tried for debugging, but none of the below helped:
  • Ran "gclient sync" 
  • Ran gclient sync -r src@HEAD
  • Reviewed  skia/BUILD.gn
Can you please help me with the error above?

P.S. - I am a long time listener first time caller for Chromedriver, and happy to be part of this vibrant community. 
Reply all
Reply to author
Forward
0 new messages