"git add ." or "git commit -am" really slow due to submodules?

820 views
Skip to first unread message

Justin Lin

unread,
Feb 25, 2013, 1:31:22 PM2/25/13
to Chromium-dev
I just switched over to the new git submodules flow, and it seems some operations now take much longer than before.

With the new submodules flow:
$ time git add .
git add .  10.58s user 1.81s system 95% cpu 12.986 total

With gclient:
$ time git add .
git add .  0.50s user 0.24s system 64% cpu 1.156 total

Is this a known issue?
I do "git commit -a --amend" sometimes, so this additional lag is kind of annoying.

Fred Akalin

unread,
Feb 25, 2013, 1:44:06 PM2/25/13
to Justin Lin, Chromium-dev
Is this on OS X? If so, I've been similar lags after switching to the new submodules workflow.


--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
 
 
 

Michael Courage

unread,
Feb 25, 2013, 1:47:18 PM2/25/13
to aka...@chromium.org, Justin Lin, Chromium-dev
Did you repeat the "ignoreSubmodules" dance from http://code.google.com/p/chromium/wiki/UsingNewGit#Initial_checkout when you made your new checkout? I've forgotten that step a couple of times when setting up new repos, and it definitely slows things down.


On Mon, Feb 25, 2013 at 10:46 AM, Michael Courage <cou...@google.com> wrote:
Did you repeat the "ignoreSubmodules" dance from http://code.google.com/p/chromium/wiki/UsingNewGit#Initial_checkout when you made your new checkout? I've forgotten that step a couple of times when setting up new repos, and it definitely slows things down.

Justin Lin

unread,
Feb 25, 2013, 1:52:57 PM2/25/13
to Fred Akalin, Chromium-dev
2013/2/25 Fred Akalin <aka...@chromium.org>
Is this on OS X? If so, I've been similar lags after switching to the new submodules workflow.

I thought it was only for my mac, but I just tried Today on my beefy Linux desktop and it has the same issue (the timings I posted are actually from my Linux desktop). It's pretty much the same timings on my mac though.

Did you repeat the "ignoreSubmodules" dance from http://code.google.com/p/chromium/wiki/UsingNewGit#Initial_checkout when you made your new checkout? I've forgotten that step a couple of times when setting up new repos, and it definitely slows things down.

Yea, I had found similar instructions, but that only seems to reduce the time for "git status", not the commands I mentioned. 

Stefan Zager

unread,
Feb 26, 2013, 12:56:31 PM2/26/13
to just...@chromium.org, Chromium-dev
On Mon, Feb 25, 2013 at 10:31 AM, Justin Lin <just...@chromium.org> wrote:
I had not noticed this before, but I can reproduce it, and I'm digging into it.

Thanks for bringing this up.

Stefan

Reply all
Reply to author
Forward
0 new messages