We did it! NotificationService is no more! (⚠️ Not web notifications; they’re fine ⚠️)

[Avi Drissman]

⚠️ This is about NotificationService, a piece of deprecated machinery inside of Chromium. This has nothing to do with the web feature of "notifications," which still works as well as it always has. ⚠️

When Chromium started as a project in the mid 2000s, we had lots of ideas about how to build it, some good, some bad. One of the bad ideas turned out to be NotificationService, which was a huge singleton that caused dependency issues. By 2013, we decided that it should be removed.

More than a decade later, many hundreds of commits later, and through the combined efforts of many dozens of committers, we have just removed the NotificationService's last usage and NotificationService itself.

I wish I could provide a comprehensive list to give credit by name to everyone who helped, but any attempt to put together a list would invariably omit someone. If you want to see what kind of effort it took, see the 200+ comments on the main bug, and follow the recursive dependencies of its 37 blocker bugs.

It's been a long journey, but I'm so proud of the Chromium community for coming together to accomplish this. We've shown that we can remove the legacy-est of legacy code, and by doing so improve the state of the Chromium code base for everyone.

To code health!

Avi

[danakj]

Wow, I was not sure if I would see this day come. Some parts of that removal were very challenging. Well done to everyone involved!

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAYxxd%3D6uS7b3fFxnc%2BgiLGKWQA3BYimhAHHj_%2BcNNkaeQ%40mail.gmail.com.

[Reilly Grant]

Congratulations! 🎉

Reilly Grant | Software Engineer | rei...@chromium.org | Google Chrome

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHtyhaR7n069Usk4syXGnZVo8u6KFfuwwDDHCZ90FT9f3Fj9NQ%40mail.gmail.com.

[Erik Chen]

Huzzah :D

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEmk%3DMYH8mCTxUO%2BJtnO1CzbBFO2bzy--nsd8Nzfted%2B4a_gww%40mail.gmail.com.

[Greg Thompson]

Wow! Congratulations.

Any volunteers to get rid of base::Singleton? :-)

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEYHnr23HrN_Wg%3DPUyTHigzcXNa%2BiSHS9nOoEZ%2BXTuNhgsYQkw%40mail.gmail.com.

[Avi Drissman]

On Thu, Jul 25, 2024 at 9:20 AM Greg Thompson <g...@chromium.org> wrote:

Any volunteers to get rid of base::Singleton? :-)

Only if we get rid of base::LazyInstance too.