virtual keyboard

[Ben Goodger (Google)]

Who uses this code still? Can we remove it?

-Ben

[Bryan Yeung]

[+hashimoto]

Ben: can you be a little more specific about precisely which code
you're talking about? Is it the code to control the virtual keyboard
overlay?

The accessibility team in Tokyo was interested in keeping it around,
last I heard. Maybe they can provide an update?

Bryan

On Tue, May 15, 2012 at 4:02 PM, Ben Goodger (Google) <b...@chromium.org> wrote:
> Who uses this code still? Can we remove it?
>
> -Ben
>

> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev

[Ben Goodger (Google)]

1. common.gypi: use_virtual_keyboard define

2. Any code controlled by that define

3. src/chrome/browser/ui/virtual_keyboard/*

As a matter of policy, we don't keep code around that "might be useful someday". That's what svn history is for. If it's unused, it should be removed, as it's in the way :-)

-Ben

[Bryan Yeung]

[+kenjibaheux, as he might have a better idea of who is working on
what within the Tokyo Chrome team]

On Tue, May 15, 2012 at 4:11 PM, Ben Goodger (Google) <b...@chromium.org> wrote:
> 1. common.gypi: use_virtual_keyboard define
> 2. Any code controlled by that define
> 3. src/chrome/browser/ui/virtual_keyboard/*
>
> As a matter of policy, we don't keep code around that "might be useful
> someday". That's what svn history is for. If it's unused, it should be
> removed, as it's in the way :-)

I can't comment on how actively the code is being used right now:
we'll have to wait for the accessibility team in Tokyo to chime in
about that.

If they're not using it, I expect that (1) & (3) can be removed
completely but there are some parts of (2) (e.g. the extension input
API) that should be teased out from the define and kept around.

Bryan

[Kenji Baheux]

+zork for IME extension API and a11y
+yusukes for his past effort on VK

As pointed by Bryan, in general VKs are quite useful for a11y (even on non-touch capable hardware). Not sure if this is what was being suggested but IMHO, we shouldn't drop the feature.

hashimoto, zork: any additional comments?

2012/05/16 5:17 "Bryan Yeung" <bry...@chromium.org>:

[Ben Goodger (Google)]

Is it a real feature, or dead code? Sadrul says use_virtual_keyboard=1 doesn't even compile.

-Ben

[Kenji Baheux]

OK, sounds like a different category of issue.
We will look into it.

Thanks!

2012/05/16 8:19 "Ben Goodger (Google)" <b...@chromium.org>:

[Ben Goodger (Google)]

If it doesn't build, I don't want you to just make it build. I do not want this code in src/chrome at all. If it doesn't build, I want it removed.

If ChromeOS needs a virtual keyboard, it should be re-implemented in src/ash.

-Ben

[Kenji Baheux]

Thanks for the clarification.

2012/05/16 8:21 "Ben Goodger (Google)" <b...@chromium.org>:

[Yusuke Sato]

Ben, I'll remove the code.

http://crbug.com/128295

-Yusuke

[Ben Goodger (Google)]

Awesome thanks!