PSA: Git fsmonitor breaks with submodules

167 views
Skip to first unread message

Avi Drissman

unread,
Aug 24, 2023, 2:29:53 PM8/24/23
to Chromium-dev
With the recent enabling of submodules, unfortunately the use of fsmonitor breaks, and you get spurious modified file errors when trying to upload changes. Sorry to be the bearer of bad news.

It's being tracked in https://crbug.com/1475405, but until then you may need to disable it with:

git config core.fsmonitor false

Avi

Joe Mason

unread,
Aug 29, 2023, 11:31:23 AM8/29/23
to Avi Drissman, Chromium-dev
Does the fsmonitor issue only apply to Mac? (I use Windows and Linux.) The bug mentions Mac several times but doesn't explicitly say that it works elsewhere.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAYPSes6R5KFXZ8z0fpGmWJpebf4%3DpniPCubwaWQO_x8NQ%40mail.gmail.com.

Dirk Pranke

unread,
Aug 29, 2023, 4:16:09 PM8/29/23
to joenot...@google.com, Avi Drissman, Chromium-dev
I don't think fsmonitor works (does anything) on Linux. I have not seen similar issues on Windows, so it might just be Mac-specific.

-- Dirk

Christian Biesinger

unread,
Sep 5, 2023, 4:26:10 PM9/5/23
to dpr...@google.com, joenot...@google.com, Avi Drissman, Chromium-dev
There's a way to make fsmonitor work on Linux using a slightly
different method
(https://chromium-review.git.corp.google.com/c/chromium/src/+/4583709);
no idea if that has the same issue though.

Christian
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTA_H8bOXntj9L4%2By4rzeXwf%3DNO_OKGfXD1Lz2u1gw4J2Q%40mail.gmail.com.

Avi Drissman

unread,
Sep 5, 2023, 4:51:00 PM9/5/23
to Christian Biesinger, dpr...@google.com, joenot...@google.com, Chromium-dev
There are two different things called "fsmonitor". One is a hook for an external executable to perform monitoring, and one is a built-in monitoring capability. The bug with fsmonitor and submodules is with the Mac implementation of the latter. The Windows implementation of the latter does not appear to have the bug, and of course you can use any number of external executables with the former, of which I don't know if they have the bug.

Avi
Reply all
Reply to author
Forward
0 new messages