Build target containing chrome.exe and dependencies

65 views
Skip to first unread message

Ken Russell

unread,
Nov 7, 2018, 9:06:48 PM11/7/18
to chromi...@chromium.org
Fellow Chromium developers: does anyone understand the build targets reasonably well and if so could you please comment on http://crbug.com/902010 ? I was trying to use mb.py's "zip" functionality to create an archive of chrome.exe (on Windows) and all of its dependencies, and for some reason, everything except chrome.exe is included in the archive - despite the fact that building the "chrome" target locally produces chrome.exe.

Thanks for any help,

-Ken

Dirk Pranke

unread,
Nov 7, 2018, 9:43:44 PM11/7/18
to Kenneth Russell, chromi...@chromium.org
I've posted a fix for the issue (we were missing a data_deps declaration in the //chrome:chrome target, so things would build correctly, but not be bundled correctly).

-- Dirk

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMYvS2c5sV%3DgJV3UGgPNhruiczJE0uKLq9tWbYA9svNDwn1tvw%40mail.gmail.com.

Nico Weber

unread,
Nov 8, 2018, 1:58:58 AM11/8/18
to Dirk Pranke, Kenneth Russell, chromi...@chromium.org
Somewhat related: On Windows, if you want to get your locally built chrome and all its dependencies on another machine, you can build the "mini_installer" target, copy over mini_installer.exe, and run it on the other machine. That way, you get exactly the files that the regular installer bundles. This may be easier than using mb (albeit it's windows-only).

Ken Russell

unread,
Nov 8, 2018, 1:33:41 PM11/8/18
to Nico Weber, Dirk Pranke, chromi...@chromium.org
Thanks Nico for the tip. I did end up using the mini_installer for this purpose, but am excited that "mb.py zip" will work portably for moving Chrome binaries around. Thank you Dirk for tracking down and fixing the root cause!

Reply all
Reply to author
Forward
0 new messages