Why delete third_party/abseil-cpp/CMake dir?

65 views
Skip to first unread message

Piasy Xu

unread,
Apr 8, 2019, 12:27:38 PM4/8/19
to Chromium-dev
Hi, I'm maintaining a set of gradle and CMake scripts to enable debugging C++ code of WebRTC in AndroidStudio (https://github.com/Piasy/webrtc/tree/hack_webrtc/sdk/android_gradle), but it seems that this commit broke my CMake script about two weeks ago, https://chromium.googlesource.com/chromium/src/third_party/+/49f1ecd3e09a240d73d48d8b8fe8641e98b29e4d , after I adding this dir back, and update the third_party/abseil-cpp/CMakeLists.txt file to the latest at https://github.com/abseil/abseil-cpp , my CMake script works fine.

Could you please add this dir back? Thanks!

mbon...@chromium.org

unread,
Apr 16, 2019, 1:52:49 PM4/16/19
to Chromium-dev
Hi,

sorry for the late reply. Yes, I can restore that directory (I have accidentally deleted it).

I plan to roll again in a couple of days.

Mirko Bonadei

unread,
May 8, 2019, 2:39:40 AM5/8/19
to Chromium-dev
Starting from yesterday the CMake dir is back: https://cs.chromium.org/chromium/src/third_party/abseil-cpp/CMake/.
Reply all
Reply to author
Forward
0 new messages