Gerrit drops +1 votes for trivial change

[Shiyi Zou]

Hi all!

I am a contributor for the Chromium project, and I found that recently the CL landing becomes harder compared with before because now the +1 votes from reviewers are reset when there is a trivial change of code, like modifying one line of code (even it's just some comments). This results in landing a small CL may take several days especially when the reviewers and I are in different time zones. Can this issue be fixed or it's intended?

Thanks!

Shiyi

[Dirk Pranke]

HI Shiyi,

The rules for resetting votes are documented here:

https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#copying-votes-to-new-patch-sets

And they are largely intentional.

Unfortunately, they don't really have a concept of a "trivial" change to a source file itself. A change to a single line of code might itself be non-trivial (making something wrong or even malicious), so this might be hard to do. A change to a comment might be a bit safer. It's possible you could file a bug asking for improvements to how things work.

Ultimately, I would guess there are two options. One is to become a committer, because I think in that case you wouldn't need a review. The second might be for the reviewer to suggest a change via Gerrit; I think it's possible in that case that that might shorten the roundtrip time, but I've rarely used this feature so I'm not sure.

Best,

-- Dirk

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/c30d46cb-b9d3-4e85-b00c-1d89bf3e5ee9n%40chromium.org.

[Joe Mason]

Another option is to ask another reviewer in the same time zone to look at the change, and mention that it's a trivial diff on the last patch. Trivial reviews shouldn't take long at all - if they do, maybe we need to improve the resources for external contributors to find reviewers.

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CALyq148cPV774u31i3BMVSPi0jhdzvf1FgkTBja1W25tbTRhpQ%40mail.gmail.com.

[Shiyi Zou]

Ok got it, thanks for your replies!