What's the best practice of pulling third party code?

[Arthur Hsu]

I'm working on pulling sfntly (sfntly.googlecode.com) to Chromium so
that our print preview feature can embed subset fonts. The current
plan is to modify DEPS so that the sfntly code is pulled to
third_party/sfntly.

There are sfntly-related code that we need in Chromium but not in
sfntly. There are only few (< 5) files. I'm wondering should I
follow the Skia model to add additional directory under src, or just
put them in third_party/sfntly. What is the best practice here?

[Evan Martin]

I would like the following directory structure:

third_party/sfntly/ # in the chrome tree
third_party/sfntly/sfntly.gyp # in the chrome tree
third_party/sfntly/README.chromium # in the chrome tree
third_party/sfntly/src # your svn checkout

This allows us to make licensing/build-flag changes without needing to
round-trip through your repository.

[Arthur Hsu]

What about subsetter.cc that's for chromium only and not belonging to
svn? Where should I put it?

[Evan Martin]

Alongside the readme etc is fine, or in its own directory if you
prefer. (I mostly just don't want them to live in the upstream
repository if they are touching Chrome code, because that layout makes
refactoring on the Chrome side difficult.)

[Darin Fisher]

Yes, we must avoid circular dependencies between source repositories!!

-Darin

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
   http://groups.google.com/a/chromium.org/group/chromium-dev

[Sheridan Rawlins]

Just to check my understanding, the LICENSE file would be in the svn checkout, and the README.chromium would have reference to it?

-SCR

[Evan Martin]

If there's an upstream LICENSE file, then yeah. Otherwise we can just
create one in the outer directory.