Do any Chromium distributions disable webrtc?

237 views
Skip to first unread message

Brett Wilson

unread,
Nov 21, 2016, 12:56:15 PM11/21/16
to Chromium-dev
The ENABLE_WEBRTC flag has a lot of ifdefs in the //chrome directory. Currently, this flag is always set except on the iOS builds, which don't use the //chrome directory any more.

Does anybody explicitly disable webrtc and use the //chrome directory? It would clean up a some code if we could assume the chrome layer always implies compiling webrtc and remove the ifdefs in //chrome. Other layers of the code would still need to check for this.

Brett

Henrik Kjellander

unread,
Nov 22, 2016, 3:24:22 AM11/22/16
to Brett Wilson, Chromium-dev, chromiu...@chromium.org
+chromium-os-dev

I'm not aware of any configurations that disable WebRTC today but a few years ago there were Chrome OS variants that had WebRTC disabled. I'm not sure of the reason, maybe it was low-end devices? I'm also not sure where to look for such configs.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

Alok Priyadarshi

unread,
Nov 22, 2016, 9:00:56 AM11/22/16
to kjell...@chromium.org, Brett Wilson, Chromium-dev, chromiu...@chromium.org
Chomecast for audio builds with enable_webrtc=false, but we do not depend on anything in //chrome directory.

The audio-device build has gotten broken a few times since none of the chromium buildbots exercise enable_webrtc=false config. We are in the process of adding an upstream buildbot: crbug.com/667546

Mike Frysinger

unread,
Nov 22, 2016, 1:34:46 PM11/22/16
to Henrik Kjellander, Brett Wilson, Chromium-dev, chromium-os-dev
i'm not aware of any CrOS builds that disable it.  it's just the gn flag "enable_webrtc" right ?  we don't use that anywhere.
-mike

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org

View archives, change email options, or unsubscribe:
Reply all
Reply to author
Forward
0 new messages