--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOuvq2122pM6mTkm-ttk%2B9E5F7d1gyeDUhW0v7gY0hRjVBvC7Q%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHk1GDwNgiAQzaf7kwXY9qSrN7jxx71Bp9W_O%2B3r8osN_WApCg%40mail.gmail.com.
It's definitely desirable to purge inactive owners and to keep OWNERS files up-to-date. But whatever policy might lead to a conclusion that Scott is not an active, competent owner, at least in the parts of the tree I'm familiar with, is an overreach. You framed this as a blanket thing, but I don't agree that "left the project" alone, at least how you seem to have interpreted it here, is a reasonable place to set the bar.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/1f9d4c8a-1fac-4ad3-8012-864a4c425dd4%40chromium.org.
I second Bruce's suggestion that it's good to involve the owner being removed first (as long as they are still responding).And I share Chris' concern that stale information about people's affiliation with the code is adding unnecessary churn, and can even be dangerous.Speaking from a very recent experience, there is a surprising amount of things to do when a person is leaving the project:
- Updating OWNERS
- Updating <owner> tags in histograms.xml
- Updating/fixing TODOs
- Updating WATCHLIST
I might even have forgotten something in the above list (suggestions welcome).Perhaps we could write a short "leaving guide" (I'm happy to volunteer) and try to get into the habit of going through it for every person which leaves. Even if the person who leaves forgets to check the above steps, they usually do have managers and team-mates who could help bringing this topic up.Cheers,
Vaclav--On Wed, 5 Dec 2018 at 02:42 <bruce...@chromium.org> wrote:I think that the person who is being removed should be the first reviewer on the CL. If they have no comment or if they are okay with it then it can be reviewed by others. That gives the owners a chance to say whether they still want to participate.--
On Tuesday, December 4, 2018 at 4:26:38 PM UTC-8, Chris Palmer wrote:On Tue, Dec 4, 2018 at 4:03 PM Mark Mentovai <ma...@chromium.org> wrote:It's definitely desirable to purge inactive owners and to keep OWNERS files up-to-date. But whatever policy might lead to a conclusion that Scott is not an active, competent owner, at least in the parts of the tree I'm familiar with, is an overreach. You framed this as a blanket thing, but I don't agree that "left the project" alone, at least how you seem to have interpreted it here, is a reasonable place to set the bar.Understood.And I would never impugn Scott's (or anyone's!) competence. I don't think I did.But indeed I am seeing areas of the code that are close to un-owned. There's no blame; this is natural. But we need to fix it, so I am trying.
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/1f9d4c8a-1fac-4ad3-8012-864a4c425dd4%40chromium.org.
If you have anonymous feedback for vabr@: go/vabr-feedback
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTBnZYJh%2BurJ3A1odFsUzhGWcxyUBxDmwESU74e%3D8Oomwg%40mail.gmail.com.
There is a fair number of OWNERs that have comments in the code review system that discourages contacting them for reviews. It's not supposed to be like that and just removing very busy owners might not make things better. At least that is better than those who are inactive with no comment. There it can take a long time (days) of experimenting until you find a reviewer.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/op.ztkf0ei3rbppqq%40cicero2.linkoping.osa.
On Wed, Dec 5, 2018 at 3:18 PM Daniel Bratell <bra...@opera.com> wrote:There is a fair number of OWNERs that have comments in the code review system that discourages contacting them for reviews. It's not supposed to be like that and just removing very busy owners might not make things better. At least that is better than those who are inactive with no comment. There it can take a long time (days) of experimenting until you find a reviewer.This is exacerbated by the fact that we have been over time trending towards OWNERS in smaller and smaller pieces of the subtree, and I wonder if we should reexamine this practice in favor of larger sets of more central (or a single set) of OWNERS.
dcheng noted that XML and related things are perhaps used only by web platform team? They should at least be co-OWNERS of all XML-related things, even if they are not the exclusive users of XML. Any volunteers or suggestions? As of those CLs, dcheng and I are the XML OWNERS, which is far less than ideal.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOuvq20%2BV2RZys%2B3uP%2B%2BUcefvHk%2B_Xe%2BYJgdy%3DWzJ9g9ASRUfQ%40mail.gmail.com.