PSA: Root of third_party now has OWNERS

Carlos Pizano

unread,

Feb 13, 2013, 9:12:50 PM2/13/13

to chromi...@chromium.org

Sorry for the late announcement. The root of third party now has an owners file. Here is how this will work:

1- New 3rd party libraries / modules do require owners approval. This might take more than few hours, can even take a few days. Plan accordingly.

2- Fixes to existing 3rd party code do not require owner approval, just TBR= one of the owners in the owners file

3- New files to an existing third party library do not require owner approval, just TBR= one of the owners in the owners file

We rely on regular reviewers to make sure that #3 is not used to circumvent #1.

The rest of the guidelines still apply : http://www.chromium.org/developers/adding-3rd-party-libraries

-cpu

Carlos Pizano

unread,

Feb 13, 2013, 9:26:25 PM2/13/13

to chromi...@chromium.org

Darn, forgot the other important point:

We want to have OWNERS files on each top level directory of third_party, for example src/third_party/skia/OWNERS

Please help with this effort.

-cpu

Lei Zhang

unread,

Feb 13, 2013, 9:41:05 PM2/13/13

to Carlos Pizano, Chromium-dev

FYI, a lot of directories under third_party are pulled in via DEPS.
You'll need to add the OWNERS file to the real location first and then
roll DEPS.

There's also some third_party directories that only show up if the
checkout have the entry for a particular platform in the .gclient
file.

> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev
>
>
>

Carlos Pizano

unread,

Feb 13, 2013, 10:14:20 PM2/13/13

to chromi...@chromium.org, Carlos Pizano

On Wednesday, February 13, 2013 6:41:05 PM UTC-8, Lei Zhang wrote:

FYI, a lot of directories under third_party are pulled in via DEPS.
You'll need to add the OWNERS file to the real location first and then
roll DEPS.

Yep, source control is hard :)

I don't have an answer for that loophole right now. I am surprised of the sheer number of them now.

There's also some third_party directories that only show up if the
checkout have the entry for a particular platform in the .gclient
file.

Sure, but CLs against them do honor the owners file, right?

Tom Hudson

unread,

Feb 14, 2013, 1:56:09 AM2/14/13

to the...@chromium.org, Carlos Pizano, Chromium-dev

Most of these third_party directories are independent libraries, right? Why should they put Chromium data in their repositories?

(Skia kinda gets around this by bringing in subdirs by DEPS, and the top level directory is a Chromium-specific creation, but that's something we've talked about getting rid of.)

Tom

Darin Fisher

unread,

Feb 14, 2013, 2:01:06 AM2/14/13

to tomh...@google.com, the...@chromium.org, Carlos Pizano, Chromium-dev

Many are pulled via DEPS from /trunk/deps in the chromium repository. I think Lei was probably referring to those copies of third party libraries.

-Darin

Lei Zhang

unread,

Feb 14, 2013, 2:12:52 AM2/14/13

to Tom Hudson, Carlos Pizano, Chromium-dev

In many cases, we have a copy of a third party library source checked
into our repo. We have already added extra files like README.chromium,
chromium.patch, .gyp files, etc.

On Wed, Feb 13, 2013 at 10:56 PM, Tom Hudson <tomh...@google.com> wrote:

Reply all

Reply to author

Forward