onbeforeunload return value stopped working

[Shachar Zohar]

Anyone noticed that returning a value from the onbeforeunload callback doesn't prompt a box to the user anymore? (from Chrome 34+)

window.onbeforeunload = function(){return "are you sure?"};

Is there a workaround? is this on purpose?

Thanks,

Shachar

[Charlie Reis]

It works for me on the 35.0.1871.0 canary.  If you have more specific repro steps to show the problem, please file a bug at crbug.com.

Charlie

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Robert Flack]

Your example is missing a call to the confirm function:

window.onbeforeunload = function(){return confirm("are you sure?")};

The "Enable fast tab/window close" flag (chrome://flags/#enable-fast-unload) will likely break this, but it is working for me without this flag on Chrome 35 canary as well.

[Charlie Reis]

Robert: no confirm call is needed for beforeunload.  The string is supposed to be displayed in the beforeunload dialog.

Charlie

[Robert Flack]

My mistake, it works without the confirm for me as well. If not working for you please do file an issue with the particular chrome version and platform.

[Shachar Zohar]

Just verifying with you guys before I'm opening the bug, it happens with addEventListener:

http://jsfiddle.net/xqR6k/

[David Benjamin]

Have you tried that in other browsers? As far as I know, return values in addEventListener aren't supposed to do anything. The addEventListener version is

window.addEventListener("beforeunload", function(ev) {

  ev.returnValue = "Blah blah blah";

});

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

[Shachar Zohar]

Well, it worked with chrome so far (33) and since 34 it stopped working

[Erik Arvidsson]

That is an intentional change to match the spec and other browsers.

https://code.google.com/p/chromium/issues/detail?id=341476

erik

[Shachar Zohar]

If I understand correctly, addEventListener doesn't propogate the return value to the browser's algorithm that handles that return value, opposed to onEvent = function(){return value} ?