Gerrit: Failed to submit change because it's "work in progress"?

[Colin Blundell]

Hi Aaron,

This change: https://chromium-review.googlesource.com/c/549461/ was just rejected by the CQ because it's "work in progress". What are the rules for when a CL is designated "work in progress"?

Thanks,

Colin

[Sylvain Defresne]

I think a CL is considered "Work in progress" until you use the "Start review" red button at the top.

It looks like it is possible to go through a whole review process without hitting that button if you use "add reviewer" link and use the grey "reply" button at the bottom of the review comment to reply to message (including automated message). Maybe this should be reported to gerrit.

-- Sylvain

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NGWHhg%3Dp9pBhNUP3oXUtWnB9dFegA9VqHuL67a3GkZKGQ%40mail.gmail.com.

[Sylvain Defresne]

It looks like a CL goes back to "work in progress" when you upload a new patchset. Is this intended?

-- Sylvain

[Aaron Gable]

Changes are marked "Work in Progress" on the very first upload. For a few hours yesterday, they were re-marked WIP with every patchset upload, but I removed that behavior (you'll need to update your depot_tools to get the fix).

You can mark the change Ready for Review (i.e. remove the WIP mode) in three ways:

* the Start Review button

* Upper right corner -> More -> WIP

* git cl upload --send-mail

Aaron

[David Roger]

On Thu, Jun 29, 2017 at 7:01 PM Aaron Gable <aga...@chromium.org> wrote:

Changes are marked "Work in Progress" on the very first upload. For a few hours yesterday, they were re-marked WIP with every patchset upload, but I removed that behavior (you'll need to update your depot_tools to get the fix).

You can mark the change Ready for Review (i.e. remove the WIP mode) in three ways:

* the Start Review button

* Upper right corner -> More -> WIP

I no longer see the More -> WIP button, is this a bug?

I have already added a reviewer using the "Add Reviewer" button, can I remove the WIP flag without spamming them with a second email?

Do I need to remove the reviewers, click "Start Review" and add the reviewers back?

 

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dMzrYY57b%2BehED%2B47Cy4FgnQOoxEHFN6f%3DaV4zx3RU%2BQ%40mail.gmail.com.

[Aaron Gable]

Changes in WIP mode don't send emails: you haven't spammed the reviewer with an email by adding them, so clicking Start Review is the right thing to do.

[Michael Giuffrida]

Does that mean, when adding a reviewer to a WIP CL, the message entered in the "Add a note for your reviewers..." textarea doesn't get sent out if you hit "Save" instead of "Start Review"?

(Re-sending from @chromium.org. Apparently Inbox forgot how to auto pick... sigh)

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2cSgO_R3WKbm3ptKvbnOPNVCxP12taMmvP0zXZQi%3D9Qxg%40mail.gmail.com.

[David Roger]

On Mon, Oct 23, 2017 at 9:46 AM Michael Giuffrida <mich...@chromium.org> wrote:

Does that mean, when adding a reviewer to a WIP CL, the message entered in the "Add a note for your reviewers..." textarea doesn't get sent out if you hit "Save" instead of "Start Review"?

Yeah... if this is how that works, it is very unintuitive and there should be some warning that the message is not actually sent.

[Aaron Gable]

That is the whole point of "Save", yes. You can change metadata (reviewers, labels, and provide a reason for doing so if you like) without spamming everyone. It still shows up in the message list at the bottom of the page, of course.

Again, if you have feedback about the gerrit UI and think something in it is unintuitive or should change, use the Send Feedback link at the bottom of the page. The gerrit devs aren't chromium devs and can't follow all of these threads.