Disabling env var override of Google API keys for Google Chrome

[Robert Shield]

Hello!

   Is anyone using the GOOGLE_CLIENT_ID_MAIN, GOOGLE_CLIENT_SECRET_MAIN, etc. environment variables to override API keys for official Google Chrome builds on any platform?

 

  They're causing problems so I plan to disable the env var override if GOOGLE_CHROME_BUILD is defined. If you know of anyone using the env vars this way, please let me know.

Thanks!

Robert

More context:

There's a bug where translate stops working for some users because their Google API keys get overridden by environment variables. It looks like some software (maybe Android Studio) sets the variables that override the API keys, breaking features of Chrome installs that use Google APIs.

[Robert Shield]

+chromium-os-dev in case CrOS uses these environment variables.

[Alexis Ménard]

Hi,

Make sure that chromium based builds are still working. I suspect lot of chromium based runtime are relying on this feature.

Thanks.

-- 
-- 
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe: 
http://groups.google.com/a/chromium.org/group/chromium-dev
--- 
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CALH7jQVtDNnsfi6-8qwYdt9_mSaVz%2B6jCWCGid%3DVt2U%2BaPdKJA%40mail.gmail.com.

[Saikrishna Arcot]

I'm using the env vars to specify the API keys to use for my Chromium PPA builds. However, I'm not setting is_chrome_branded to true, so I believe this would count as an unofficial build.

[Robert Shield]

On Mon, Jun 26, 2017 at 10:16 PM, Saikrishna Arcot <saiar...@gmail.com> wrote:

I'm using the env vars to specify the API keys to use for my Chromium PPA builds. However, I'm not setting is_chrome_branded to true, so I believe this would count as an unofficial build.

That's correct, anything that doesn't #define GOOGLE_CHROME_BUILD won't be affected by this change.