Building Chromium on Windows. ERROR at //skia/BUILD.gn:233:14: Undefined identifier

[Oleksii Kadurin]

Hi! I'm following the instruction in here https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md#Setting-up-Windows .

All the needed components (VS2015, SDK) are installed successfully.

But it fails when I run the next command:

gn gen out/Default

Is outputs:

c:\chromium\src>gn gen out/Default
ERROR at //skia/BUILD.gn:233:14: Undefined identifier
  sources += skia_xps_sources
             ^---------------
See //BUILD.gn:209:5: which caused the file to be included.
    "//skia:skia_unittests",
    ^----------------------

Could you please help me with that issue? Thanks in advance!

[Paweł Hajdan, Jr.]

Some quick things to check:

1. Did you run gclient sync?

2. Did you possibly check out a broken revision? Try updating the checkout, and remember to run "gclient sync" again.

Paweł

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Oleksii Kadurin]

Hi Paweł! 
Thank you! Running gclient sync helped. 

I usually do "git pull --rebase origin master". And thought that it's the same as "gclient sync"

[Christian Biesinger]

They're actually unrelated -- after git pull you always have to do gclient sync as well (and you have to git pull before gclient sync or it won't do anything useful).

Christian

[Oleksii Kadurin]

Thank you for information!