Build failure with is_official_build = true on master with Mac OS X

[Anton Marini]

Hello

Attempting to build Chrome with is_official_build = true in my args.gn with a recent master (git commit 79e086824558cb015da9e0fc238bed9ce476db1c) - results in the following error :

../../remoting/host/remoting_me2me_host.cc:137:10: fatal error: 'remoting/tools/internal/internal_mac-inl.h' file not found

#include "remoting/tools/internal/internal_mac-inl.h"

         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

My workflow was, git pull, run gclient sync, and ninja -C out/Default

I was told running is_official_build was the correct way to build a stand-alone build of Chromium as a distributable binary (I'd like to share some work with non developers in an easy way).

I understand its pretty clear from the paths / error message that is_official_build is referencing "internal" and thus likely non public sources (to those that aren't Google employees).

Is there a build switch to build a distributable Chromium Binary that does not link libraries in the build directory? 

Thank you in advance, and apologies if this is documented somewhere.

[Scott Nichols]

I think to get around this, try adding enable_remoting=false in your gn args and it will not attempt to build the remoting directory.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

[Nico Weber]

I think this is a bug. is_official_build is supposed to mean "use optimization settings like for an official build" while internal stuff should be keyed off is_chrome_branded. So you should be able to build with that set. Having said that, it's likely that not many people test is_official_build without is_chrome_branded on mac, so you might need to contribute some patches to get that working.`

--

[Lambros Lambrou]

I think "ninja -C out/Default" will try to build absolutely everything, including remoting/. If you're only interested in building Chrome (or whatever), just specify the thing you want to build: "ninja -C out/Default chrome"

BTW, we are fixing the "internal_mac-inl.h" error in remoting/, which will moot the question of is_official_build versus is_chrome_branded :)

[vade]

Oh jeez. That would make sense wouldn't it.

I'll give that a try tomorrow. Very much appreciate the feedback.

Thank you.

[Anton Marini]

Thanks, this is now working - after fiddling with some additional build arguments I am able to build a stand alone / distributable chromium.