Adding H.264 support for the Android app

[אבי וזהו‎]

Hi,

I was following this guide for building the android app.

I noted that there is no support for H264 videos.

How can i add the H264 support to the build?

Thanks

Avi

[PhistucK]

H.264 is not a free codec. If you have the license for distributing an H.264 decoder, you can enable it via some configuration.

There is a blanket build time flag for all of the non-free codecs -

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/9EqnUb2fDvg/PTFsVoIRBTUJ

If you want to only add H.264 (but not AAC for example, which usually goes along with it), you will have to search the code a bit to see how it enables hardware H.264 support (since this is an Android build and Android usually works with devices that have a hardware H.264 decoder).

Also, media-dev might be more helpful.

☆PhistucK

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/8a51392e-830f-44c4-bda8-dfa3e9bf841c%40chromium.org.

[PhistucK]

For searching the code quickly - cs.chromium.org.

☆PhistucK

[Tima Vaisburd]

Try to add argument

ffmpeg_branding = "Chrome"

in your GN args

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABc02_%2BHiP-x2mh8JqPWC0%3DebUfApZAgAihFKQgiBCCU7W8y%2BQ%40mail.gmail.com.

[אבי וזהו‎]

Hi,

hanks for your help, It's much appreciated.

I tried to run the flowing commands:

1: export GYP_DEFINES='proprietary_codecs=1 ffmpeg_branding=Chrome'

2: gclient runhooks

3: gn gen --args='target_os="android"' out/Default

4: ninja -C out/Default chrome_public_apk

And it didn't seem to add the h264 to the app

Then i tried to run

1: gn gen --args='target_os="android" ffmpeg_branding = "Chrome"' out/Default

2: ninja -C out/Default chrome_public_apk

And also it didn't work

Any suggestions on what am i doing wrong?

Thanks

Avi

[PhistucK]

The spaces you added seems wrong and you omitted one of the arguments in the GN version.

I think it should be -

gn gen --args='target_os="android" proprietary_codecs=1 ffmpeg_branding=Chrome' out/Default

(Maybe even without the quotes around "android")

Does that work for you?

☆PhistucK

--

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/fc703cf1-d0cd-4a43-adbe-93250d2658ed%40chromium.org.

[אבי וזהו‎]

Hi,,

Thanks a lot 

This command worked:

gn gen --args='target_os="android" proprietary_codecs=true ffmpeg_branding="Chrome"' out/Default

Thanks again

Avi

☆PhistucK

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

[HimmaH]

Hi, can You tell me which guide you followed to build android app?

I am trying to show H264 videos on android app using webrtc.

[אבי וזהו‎]

Hi,

I was following this guide: https://chromium.googlesource.com/chromium/src/+/master/docs/android_build_instructions.md#Get-the-code

Thea's are the steps for allowing the video and building the android APK:

1: export GYP_DEFINES='proprietary_codecs=1 ffmpeg_branding=Chrome'

2: gclient runhooks

3: gn gen --args='target_os="android"' out/Default

4: ninja -C out/Default chrome_public_apk

5: gn gen --args='target_os="android" ffmpeg_branding = "Chrome"' out/Default

6: gn gen --args='target_os="android" proprietary_codecs=true ffmpeg_branding="Chrome"' out/Default