Does chromium allow cherry-picking upstream change of third_party?

33 views
Skip to first unread message

Byoungchan Lee

unread,
Jul 29, 2021, 4:02:25 PM7/29/21
to Chromium-dev
I would like to cherry-pick the upstream change [1] of OCMock (Objective-C Mock Library), in order to clean up the old hack in WebRTC [2],

This change is not my own change, so I don't know if it's valid for me to create the CL as the owner. Any advice?

BTW, OCMock is stuck on 3.1.5 which was released 6 years ago. Because Upstream OCMock requires OSX 10.11 [3]. However, according to https://crubg.com/1153883, chromium removed OSX 10.10 support, so it would be nice to upgrade this dependency.

[1] https://github.com/erikdoe/ocmock/pull/239
[2] https://source.chromium.org/chromium/chromium/src/+/ab30d72b724b185c6d3404d5f52096ce0b1f76a0:third_party/webrtc/sdk/objc/unittests/RTCAudioSessionTest.mm;l=214
[3] https://source.chromium.org/chromium/chromium/src/+/1ed951ebd7e4f14c62d5e96aacfafac7ee4e0678:third_party/ocmock/README.chromium

Confidential / 대외비

CONFIDENTIALITY NOTICE: This e-mail communication and any attachments contains confidential and privileged information for the sole use of the designated recipients named above. It is prohibited to disclose, disseminate, distribute or copy this e-mail and any attachments beyond the scope which is mutually agreed with the sender of this e-mail. If you are not the intended recipient, please notify the sender by return e-mail and delete and/or destroy all copies of this communication and any attachments immediately.

 이메일  첨부파일은 지정된 수신인만을 위한 것이며회사의 비밀정보를 포함합니다 정보를 발신인과 합의된 범위 외에 사용공개배포하는 것은 엄격히 금지됩니다귀하가 만일 지정된 수신인이 아닌 경우발신인에게  사실을 통지해 주시고 원본 이메일과 첨부파일  모든 사본을 즉시 삭제하여 주시기 바랍니다.

Robert Sesek

unread,
Jul 29, 2021, 4:15:43 PM7/29/21
to dani...@hpcnt.com, Chromium-dev
Per the README.chromium in the OCMock, Chromium does carry local cherry-picks, so yes this is possible. But as you note, we can probably uprev the library now that we no longer support OS 10.10.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/3b127a43-83ed-4d63-a365-9bc673efbda3n%40chromium.org.
Reply all
Reply to author
Forward
0 new messages